Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese translations #752

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Chinese translations #752

merged 1 commit into from
Dec 8, 2023

Conversation

jamesliu96
Copy link
Contributor

No description provided.

@jamesliu96
Copy link
Contributor Author

jamesliu96 commented Dec 8, 2023

My last merged (#745) commit used a wrong user name & email (work email) unfortunately which caused a problem with my company. Would you please, if possible, edit the commit author information to match my public user name (James Liu) & email (jamesliu96@users.noreply.github.com), perhaps with a simple rebase, referencing the method at https://stackoverflow.com/questions/3042437/how-can-i-change-the-commit-author-for-a-single-commit .

@forrestguice
Copy link
Owner

forrestguice commented Dec 8, 2023

I've re-based and replaced the author info for that commit. I hope I've this done correctly without creating a mess (hard to say).

I did notice afterward the old commit info was still present in the history; doing git gc cleared it from my local copy. I've requested that GitHub remove any cached views, so hopefully traces of the old commit disappear soon.

#680 #681

@forrestguice forrestguice added translation zh_TW Traditional Chinese zh_CN Simplified Chinese labels Dec 8, 2023
@forrestguice forrestguice added this to the v0.15.10 milestone Dec 8, 2023
@forrestguice forrestguice merged commit ba9367b into forrestguice:master Dec 8, 2023
1 check passed
@jamesliu96
Copy link
Contributor Author

I don't know express how grateful I am. And, sorry for all the trouble I've made. I'll inspect my commit info well before any public push from now on.

@forrestguice forrestguice mentioned this pull request Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation zh_CN Simplified Chinese zh_TW Traditional Chinese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants