Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 125 #130

Merged
merged 15 commits into from
Dec 21, 2017
Merged

fix 125 #130

merged 15 commits into from
Dec 21, 2017

Conversation

forrestguice
Copy link
Owner

fixes #125, #129, & misc issues / potential leaks flagged by lint

use slide_in (doesn't seem to suffer from same problem as fade_in) (#125)
Log a warning when SuntimesUtils is used to format a time without also being initialized..

..these warnings are showing up when successfully triggering #129 - it seems the cause of the bug is using a SuntimesUtils class definition whose static initDisplayStrings method hasn't been called.

..the reason the bug doesn't occur every time (or even most times) is because this init code is called frequently by other widgets and activities, correctly setting up the utils, but the flippable widget has its own update code that might be called independently (which doesn't initialize the utils).

..the reason the bug occurs more frequently when installing via adb is because this kills the running application (disposing of any previously initialized SuntimesUtils class def), creating the necessary conditions for the bug to occur. If the flippable widget is first to update then the bug is apparents, but if another widget goes first the problem gets masked.
call initLocale (and initDisplayStrings) from onDataSetChanged, so that later when getView is called SuntimesUtils is initialized and ready. #129
keyboard inaccessible widget; `clickable` items should also be `focusable`
refactor LightMapTask to be static
refactor TimeZonesLoadTask to use listener (and eliminate potentially leaky non-static anon class)
listener now uses WeakReference to avoid leaks; don't forget to keep a reference!
listener now uses WeakReference to avoid leaks; don't forget to keep a reference!
This reverts commit 10ef072.
This reverts commit d48e23f.
@forrestguice forrestguice merged commit 0f9a457 into master Dec 21, 2017
@forrestguice forrestguice deleted the fix-125 branch December 21, 2017 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

table switch animation fails to play
1 participant