-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 125 #130
Merged
Merged
fix 125 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use slide_in (doesn't seem to suffer from same problem as fade_in) (#125)
Log a warning when SuntimesUtils is used to format a time without also being initialized.. ..these warnings are showing up when successfully triggering #129 - it seems the cause of the bug is using a SuntimesUtils class definition whose static initDisplayStrings method hasn't been called. ..the reason the bug doesn't occur every time (or even most times) is because this init code is called frequently by other widgets and activities, correctly setting up the utils, but the flippable widget has its own update code that might be called independently (which doesn't initialize the utils). ..the reason the bug occurs more frequently when installing via adb is because this kills the running application (disposing of any previously initialized SuntimesUtils class def), creating the necessary conditions for the bug to occur. If the flippable widget is first to update then the bug is apparents, but if another widget goes first the problem gets masked.
call initLocale (and initDisplayStrings) from onDataSetChanged, so that later when getView is called SuntimesUtils is initialized and ready. #129
keyboard inaccessible widget; `clickable` items should also be `focusable`
refactor LightMapTask to be static
refactor TimeZonesLoadTask to use listener (and eliminate potentially leaky non-static anon class)
listener now uses WeakReference to avoid leaks; don't forget to keep a reference!
listener now uses WeakReference to avoid leaks; don't forget to keep a reference!
This reverts commit 10ef072.
This reverts commit d48e23f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #125, #129, & misc issues / potential leaks flagged by lint