Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add day length difference from the day before and fix minute symbol #773

Closed
bugith opened this issue Feb 17, 2024 · 4 comments · Fixed by #784
Closed

Add day length difference from the day before and fix minute symbol #773

bugith opened this issue Feb 17, 2024 · 4 comments · Fixed by #784
Milestone

Comments

@bugith
Copy link

bugith commented Feb 17, 2024

Great App !
The symbol of minute is min, not m (m stands for meter) : p145/147 The International System of Units (SI)

It would be nice if we had how many min-s we have from the day before, this way:
Screenshot_20240217-182015

@verdulo
Copy link
Contributor

verdulo commented Feb 18, 2024

I corrected the unit in translations to Polish and Esperanto. Just edit the following string:

<string name="delta_minutes">m</string> <!-- e.g. 3m -->

@bugith
Copy link
Author

bugith commented Feb 18, 2024

"min" is ISO, shouldn't be translated.
Also, I'm not a coder to understand if what I read on line 173 (link) is related to the delta time feature I proposed in this very issue, but I though it is better to show Today minus Yesterday instead of Tomorrow minus Today (or Day minus Day-1). Just a thought.

forrestguice added a commit that referenced this issue Feb 18, 2024
Replaces the minutes abbreviation "m" with "min" for all translations that default to METRIC to avoid ambiguity with meters (#773, #774); leaves the translations that have overridden this value (zh, ru, hu).
@forrestguice
Copy link
Owner

Thanks for taking time to report.

This feature will be added to the main app soon. I've been meaning to add it for awhile actually, but somehow it keeps slipping my mind. Its already available for widgets (since a very early version).

I though it is better to show Today minus Yesterday instead of Tomorrow minus Today (or Day minus Day-1).

The widgets have "show comparison" and "compare against" (today/yesterday) options. It will be the same for the app.

"min" is ISO, shouldn't be translated.

Almost every string in the app is translatable, so as to give translators ultimate control over what appears on the screen. e.g. the Chinese, Russian, and Hungarian translations have replaced these symbols entirely.

I might argue that "m" vs "min" isn't a problem so long as their isn't any ambiguity - both are widely understood. However, the lower left hand corner of your screenshot has"m" in the context of meters, and that same ambiguity appears again in "sun position" dialog.

So I've gone ahead and changed this from "m" to "min" for in all the translations that default to METRIC.
I've left it unchanged for "American English" (en_US)).

@bugith
Copy link
Author

bugith commented Feb 19, 2024

Thanks to you for extensive answer Forrest. Nice App and great Dev !

forrestguice added a commit that referenced this issue Mar 16, 2024
adds "show comparison" and "compare against" to app "user interface" settings (#773)
forrestguice added a commit that referenced this issue Mar 16, 2024
implements "show comparison" and "compare against" app options (#773)
@forrestguice forrestguice added this to the v0.15.13 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants