Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Date limited to 1000 days in the past #770

Closed
kshpytsya opened this issue Feb 12, 2024 · 2 comments · Fixed by #778
Closed

View Date limited to 1000 days in the past #770

kshpytsya opened this issue Feb 12, 2024 · 2 comments · Fixed by #778
Labels
Milestone

Comments

@kshpytsya
Copy link

Attempts to "View Date" more than 1000 days in the past or in the future are silently ignored.

To Reproduce
Steps to reproduce the behavior:

  1. Click the "..." menu
  2. Click "View Date" menu item
  3. Pick any date that is three years (3*365=1095) in the future or in the past
  4. Click check mark to confirm date selection
  5. See that the chosen date is silently ignored, leaving previously selected date, and a confused user.

Expected behavior
It should be possible to view arbitrary date not limited to -1000..+1000 days from today. If this is really impossible for some valid reason, the date selector should indicate that with some explanation, and make it impossible to select an unsupported date. Also, if already displaying non-current date on the main screen, date selector should start with that date selected, and not today's date.

Version Info:

  • App Version: 0.15.11 (4969294)
  • Android Version: 14; 9.0
  • Device Model: Pixel 8 Pro; Galaxy S10e
forrestguice added a commit that referenced this issue Feb 13, 2024
"If already displaying non-current date on the main screen, date selector should start with that date selected, and not today's date." (#770)
forrestguice added a commit that referenced this issue Feb 13, 2024
"The date selector should make it impossible to select an unsupported date." (#770)
@forrestguice
Copy link
Owner

forrestguice commented Feb 13, 2024

Thanks for the feedback. I appreciate it.
Issues with the date selector will be fixed in the next patch version.

I'm curious about your use case, if you can share more details.
How many years into the past/future are you interested, and for what purpose?

The current +-1000 days limitation is arbitrary, but even with technical limitations on the date range, it should be possible to allow selection of +- hundreds of years. e.g. the underlying library, Time4J, allows for dates up to year 3000, but I'm a bit dubious of the accuracy/result.

forrestguice added a commit that referenced this issue Feb 13, 2024
newApi (#770)
@kshpytsya
Copy link
Author

My specific use case which led me to this discovery was trying to go back to the year of my birth (1979) to determine the date of Chinese New Year, which is the second new moon after the winter solstice. So, a one-off use case but why not.

forrestguice added a commit that referenced this issue Feb 22, 2024
increase capacity of card adapter; from +-2.5 years to +-500 (#770)
@forrestguice forrestguice added this to the v0.15.12 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants