Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very big font size for date widget #763

Closed
islam2hamy opened this issue Jan 25, 2024 · 8 comments · Fixed by #767 or #778
Closed

Very big font size for date widget #763

islam2hamy opened this issue Jan 25, 2024 · 8 comments · Fixed by #767 or #778
Labels
Milestone

Comments

@islam2hamy
Copy link

Describe the bug
Very big font size for date widget

To Reproduce
Steps to reproduce the behavior:

  1. Add date widget
  2. Chnge format as in Screenshot

Expected behavior
best fit , small font size widget

Screenshots
IMG_٢٠٢٤٠١٢٥_٠٥٢٢٥٠

Version Info:

  • App Version: 0.15.10
  • Android Version: 14
  • Device Model: Redmi Note 12
forrestguice added a commit that referenced this issue Jan 28, 2024
adjust text size using StaticLayout (#763)
@forrestguice forrestguice added this to the v0.15.11 milestone Jan 31, 2024
@forrestguice
Copy link
Owner

forrestguice commented Jan 31, 2024

v0.15.11 changes the way the text scaling is implemented.
It fixes other bugs I've observed, so it might fix this problem too.

After testing (sometime next week), please post a comparison screenshot, and reopen the issue if its not fixed.

@islam2hamy
Copy link
Author

Thank You

@islam2hamy
Copy link
Author

Not fixed with all formats :(

@islam2hamy
Copy link
Author

Ps. Using kiss launcher

@forrestguice
Copy link
Owner

forrestguice commented Feb 11, 2024

Well that's a shame :\
With the recent implementation, the scaling look better to me, but I'm mostly testing in English (with a left-to-right layout).
I suspect these are contributing factors that I'll need to explore.

Which patterns specifically are broken?
Are there other patterns that actually seem improved or have changed?

Please list out each "date pattern" (text appearing below the "date format"), with a screenshot if possible.
I'll try to reproduce the problem more closely.

@forrestguice forrestguice reopened this Feb 11, 2024
@islam2hamy
Copy link
Author

no problem bro

IMG_٢٠٢٤٠٢١٣_٢٠٥٨٥٦
IMG_٢٠٢٤٠٢١٣_٢٠٥٧١٣
IMG_٢٠٢٤٠٢١٣_٢٠٥٦٥٧

forrestguice added a commit that referenced this issue Mar 1, 2024
refactors adjustTextSize to use StaticLayoutBuilder (#763)
forrestguice added a commit that referenced this issue Mar 1, 2024
@forrestguice
Copy link
Owner

Hopefully this is actually fixed.
I couldn't reproduce it exactly, but on a hunch enabled a developer setting that draws the margins/paddings as lines. Afterward I noticed the text was slightly offset by a few pixels instead of centered. Examining your second screenshot, the text actually looks like its the correct size, but its also offset from center (by a lot!). Anyhow, the layout was refactored.

@islam2hamy
Copy link
Author

Fixed
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants