Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't interact with app after install. Flashes/strobes (seizure warning) #760

Closed
Phoenix616 opened this issue Jan 11, 2024 · 3 comments · Fixed by #756
Closed

Can't interact with app after install. Flashes/strobes (seizure warning) #760

Phoenix616 opened this issue Jan 11, 2024 · 3 comments · Fixed by #756
Labels
Milestone

Comments

@Phoenix616
Copy link

Phoenix616 commented Jan 11, 2024

Describe the bug
After installing the app and opening it one can't interact with it and it flashes/strobes between the screen where you press "next" and some font option/welcome screen. (Also switching to another app is difficult from the app switcher. (See video))

To Reproduce
Steps to reproduce the behavior:

  1. Install app (from F-Droid)
  2. Open it
  3. Have observe described behaviour

Expected behavior
For the app to work and not have some seizure-inducing strobeing effect...

Screenshots

Video from the effect (seizure warning!)
video_2024-01-11_15-13-57.mp4

Version Info:

  • App Version: 0.15.9
  • Android Version: 13 (LineageOS 20-20231021-NIGHTLY-beyond0lte)
  • Device Model: Samsung Galaxy S10e (beyond0lte)

Additional context
Looks like it's re-opening the app again and again to me

@forrestguice
Copy link
Owner

Thanks for the report.
Is it doing this with the previous version v0.15.8?

There were recent changes in the welcome activity, so I'm thinking this behavior is something I might have introduced then.

@Phoenix616
Copy link
Author

0.15.8 seems to not have the issue.

forrestguice added a commit that referenced this issue Jan 14, 2024
Avoid triggering the theme spinner's `onItemSelectedListener` during initialization; changes to the selection trigger an activity recreate, so the listener must not be fired when the selection is initialized (#760).
@forrestguice forrestguice added this to the v0.15.10 milestone Jan 14, 2024
@forrestguice
Copy link
Owner

forrestguice commented Jan 23, 2024

Thank you again for reporting this. It should be fixed in v0.15.10.
To test it, either navigate Settings -> General -> Welcome Screen, or reset/clear app storage.

I couldn't reproduce the bug on my devices for some reason, but the problem is apparent. The activity is recreated whenever the selected theme is changed; the flashing observed is the activity finishing/starting over and over (infinite loop).

The bug was introduced after refactoring the "theme buttons" to a spinner. For some reason the spinner's onValueChanged listener is being fired when initialized. Maybe some internal behavior is recently changed, or some accessibility related option is responsible 🤷, but I thought I was already taking necessary precautions. The fixed listener now tracks its initial position (to avoid firing unnecessarily).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants