Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom date format is not saved #759

Closed
ghost opened this issue Jan 10, 2024 · 3 comments · Fixed by #756
Closed

custom date format is not saved #759

ghost opened this issue Jan 10, 2024 · 3 comments · Fixed by #756
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Jan 10, 2024

Describe the bug
A clear and concise description of what the bug is: When using Date format ^custom in changing to Rolex Oyster Perpetual (Wed, Jan 1) "EE, MMM d" does not stay set and reverts to default.

To Reproduce
Steps to reproduce the behavior:

  1. Go to settings , widgets, date widget, date format dropdown , Custom
  2. Input custom date format "EE, MMM d" checkmark save
  3. See date format on widget has not change to Rolex Oyster Perpetual
  4. open settings again to see "EE, MMM d" not set

Expected behavior
A clear and concise description of what you expected to happenin:Expect to see a widget with a date format such as "Wed, Jan 1"

Screenshots
If applicable, add screenshots to help explain the problem: Upon request.

Version Info:

  • App Version: 0.15.9
  • Android Version: 10
  • Device Model: Pixel variant

Additional context
Add any other information about the problem here.

@forrestguice
Copy link
Owner

Thanks for taking time to report.
I think I've figured out why this isn't working. It should be fixed in v0.15.10.

In the meantime, I think you can "force it" to work by clicking enter/accept on the onscreen keyboard first (and then afterward clicking save at the top).

The underlying problem is that custom format isn't applied until the textview loses focus, so clicking save while it still has focus effectively discards the changes.

@forrestguice forrestguice changed the title Rolex Oyster Perpetual custom date format is not saved Jan 10, 2024
@ghost
Copy link
Author

ghost commented Jan 11, 2024

Thanks for taking time to report. I think I've figured out why this isn't working. It should be fixed in v0.15.10.

Not too many. Did you make all of this yourself? Quite some talent behind this app.

In the meantime, I think you can "force it" to work by clicking enter/accept on the onscreen keyboard first (and then afterward clicking save at the top).

Hacker's Keyboard displays "DONE" but tapping into another field does the trick to commit change upon focus shift. It seems "DONE" is not enter in which case it wouldn't be a bug I likely naturly tried this. Do you happen to know the key mapper code for "RETURN"?

The underlying problem is that custom format isn't applied until the textview loses focus, so clicking save while it still has focus effectively discards the changes.
Your explanation does the trick to commit change upon focus shift before save.

I also noticed you changed my reporting a bug title. The Display is actually to be modeled after Rolex Oyster Perpetual Day-Date 40 which is a sort of minimal display for you could vector the year and month according to the combination of Day and Date.

@forrestguice
Copy link
Owner

Thank you, and yeah, this app is a personal project for many years now.

Do you happen to know the key mapper code for "RETURN"?

Sorry, I don't know. I mentioned the keyboard because it seemed like the quickest way to lose focus, but maybe its a contributing factor too.

I also noticed you changed my reporting a bug title.

I think how you reported it was fine. The bug occurs when entering any custom date format though, so I changed it to what will be noted in the changelog.

btw, I wasn't previous familiar with this format. We can add it to the list of defaults if you think its something others might want too.

forrestguice added a commit that referenced this issue Jan 14, 2024
adds pattern "EE, MMM d" (#759)
forrestguice added a commit that referenced this issue Jan 14, 2024
@forrestguice forrestguice added this to the v0.15.10 milestone Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant