Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app crash on "Set Date" api10 #75

Closed
forrestguice opened this issue Jan 13, 2017 · 0 comments
Closed

app crash on "Set Date" api10 #75

forrestguice opened this issue Jan 13, 2017 · 0 comments
Labels
api10 bug
Milestone
v0.3.0

Comments

@forrestguice
Copy link
Owner

tested on emulator api10.
"Set Date" -> the dialog fails to appear, instead the app crashes.

java.lang.IllegalArgumentException: current should be >= start and <= end
            at android.widget.NumberPicker.setCurrent(NumberPicker.java:288)
            at android.widget.DatePicker.updateDaySpinner(DatePicker.java:397)
            at android.widget.DatePicker.updateSpinners(DatePicker.java:383)
            at android.widget.DatePicker.init(DatePicker.java:379)
            at com.forrestguice.suntimeswidget.TimeDateDialog.initViews(TimeDateDialog.java:126)

values are -1 -1 -1 (init called before values are initialized)
tested on api19 no crash.
forrestguice added a commit that referenced this issue Jan 13, 2017
@forrestguice
fix crash api10
87a3b5e 
api10 DatePicker.init doesn't like invalid values like -1, later
versions seem to tolerate them. #75
@forrestguice forrestguice added this to the v0.3.0 milestone Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api10 bug
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
1 participant
@forrestguice