Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] year-long sunrise+sunset graph/calendar #735

Closed
jmangel opened this issue Oct 11, 2023 · 8 comments · Fixed by #811 or #821
Closed

[Feature request] year-long sunrise+sunset graph/calendar #735

jmangel opened this issue Oct 11, 2023 · 8 comments · Fixed by #811 or #821
Milestone

Comments

@jmangel
Copy link

jmangel commented Oct 11, 2023

Would it be possible to add a widget to display a graph of sunrise and sunset times across the year, along with a "you are here" indicator.

Date would be on the x-axis, time on the y-axis
Dates from jan-dec
Two lines: one for sunrise, one for sunset
The lines would "skip"/jump at daylight savings time changes (if applicable to location)
The "you are here" indicator would be at (x,y) coordinates where x=current date, and y=current time

I would be happy to help develop this if you're open to it
download (2)

@forrestguice
Copy link
Owner

Thanks for the suggestion. That's a nice graph - I'm somewhat familiar with it already.
I'll consider adding some version of it. 👍

Also, I appreciate your offer to help develop, however my preference is to write that code myself (for various reasons).
I think imagining how software should work is often the harder task though. It is nice to have well defined requirements, usecases, or similar guidance. I like the way you've outlined this feature already.

If you really wanted to code this yourself, or just get your hands dirty, another possibility exists as an "addon". This is technically a separate app that is capable of very close integration with Suntimes (made possible by various interfaces). For example, Natural Hour accesses the app's configuration through a content-provider to add its own features. I'd be willing to help navigate these interfaces (or extend them further if necessary). I'd also be willing to promote any completed addons from the project README. I think there are definitely some advantages to adding features this way (e.g. complete freedom of implementation), but also some obvious disadvantages (added complexity from IPC). Anyhow, I mention it as another way to add features to Suntimes in general.

@forrestguice
Copy link
Owner

@jmangel This should be on F-Droid any day now. It usually takes a week.

I'm re-reading the requirements though and it seems I missed a detail (or two), so you may be disappointed this feature isn't complete. It currently fails to show the jump at DST, instead always centering on local mean time and shifting the axis labels.

@forrestguice forrestguice reopened this Aug 6, 2024
@jmangel
Copy link
Author

jmangel commented Aug 6, 2024

I'm re-reading the requirements though and it seems I missed a detail (or two), so you may be disappointed this feature isn't complete. It currently fails to show the jump at DST, instead always centering on local mean time and shifting the axis labels.

I appreciate the follow-up!

forrestguice added a commit that referenced this issue Aug 9, 2024
shows jump/skip in time zone dst while maintaining center on local mean time (#735).
@jmangel
Copy link
Author

jmangel commented Aug 20, 2024

The widget actually looks amazing! Here is a screenshot comparing it to the previous website widget I was using, and it's much better for several reasons. I do see what you're saying about not jumping for DST, but that only happens in-app and not in the widget, which is interesting, but the widget was my main use case. Thanks so much!

Screenshot_20240807-213512

@jmangel
Copy link
Author

jmangel commented Aug 22, 2024

I actually ran into an issue with it today, I'm not sure what prompted it, I did add a couple other widgets but didn't intentionally change any settings. But there's a gap on the light graph in the middle of the year. Lmk if you have any ideas or questions for me to reproduce
Screenshot_20240822-094345

Screenshot_20240822-094423

@forrestguice
Copy link
Owner

forrestguice commented Aug 22, 2024

I recognize this bug. I realized shortly after tagging v0.16.0 that there were a bunch of problems that worsened with latitude, and (literal) edge cases, etc. I guess that sort of thing is normal for a .0 release (but still embarrassing).

It has since been rewritten a bit, so should be fixed with v0.16.1, probably on F-Droid within the next week.

btw its fun seeing those screenshots. I see that the new color tool was used. That's another feature that's a little rough around the edges, that I hope to improve over the next few months.

@jmangel
Copy link
Author

jmangel commented Aug 22, 2024 via email

@jmangel
Copy link
Author

jmangel commented Aug 28, 2024

0.16.1 seems to have caused some other issues, the light graph and world map widgets aren't working at all, just a thin black bar. And when I try to open the widget settings, the app either crashes, or "redirects" to the home screen

forrestguice added a commit that referenced this issue Aug 28, 2024
fixes crash in sunlight widget (#735)
@forrestguice forrestguice modified the milestones: v0.16.0, v0.16.1, v0.16.2 Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants