Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese lunar calendar? #692

Closed
petep0p opened this issue Feb 10, 2023 · 2 comments · Fixed by #694
Closed

Chinese lunar calendar? #692

petep0p opened this issue Feb 10, 2023 · 2 comments · Fixed by #694
Milestone

Comments

@petep0p
Copy link

petep0p commented Feb 10, 2023

not so much an issue, and more of a feature request. i really like the new date widget with the different calendar options but i would really love to see the Chinese Yin/Xia lunisolar calendar as an option. would that be possible in a future update?

forrestguice added a commit that referenced this issue Feb 12, 2023
adds Chinese, Korean, and Vietnamese calendars (#692);
@forrestguice
Copy link
Owner

I think this should be possible.
The date widget uses the Time4J library, so its relatively easy to add other calendars supported by this library. If a calendar isn't supported, then it might be possible to get it added to the library (and eventually part of the widget).

I will add http://www.time4j.net/javadoc-en/net/time4j/calendar/ChineseCalendar.html in v0.15.1, but I'm not entirely sure its what was requested. Those docs point to https://en.wikipedia.org/wiki/Chinese_calendar, which mentions the Xia calendar in a historical sense, so I'm assuming this is actually a modernized version with different rules? I'm also unsure if all of the elements are "formattable" (e.g. "solar term"), so it might be impossible to display some patterns.

@forrestguice forrestguice added this to the v0.15.1 milestone Feb 12, 2023
@petep0p
Copy link
Author

petep0p commented Feb 13, 2023

thank you! that would absolutely fulfill my request. i don't pretend to be an expert on it, and that does seem like a more complicated calendar than some others, so whatever info you're able to add into the widget will be awesome. mainly I'd just like to see the major holidays with less guesswork and on my home screen.

much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants