Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solar noon incorrect when rise/set spans today/tomorrow #65

Closed
forrestguice opened this issue Sep 29, 2016 · 1 comment
Closed

solar noon incorrect when rise/set spans today/tomorrow #65

forrestguice opened this issue Sep 29, 2016 · 1 comment
Labels
Milestone

Comments

@forrestguice
Copy link
Owner

Using a user-defined timezone set to UTC, the rise time is 1:24PM UTC and set time is 1:16AM UTC (next day). The solar noon time should be 7:20 PM, but instead shown as 7:20AM. When using the system timezone the solar noon time is correctly shown as 12:20PM, and when using other user-defined timezones (EST for example) the solar noon time is correctly shown in that timezone.

@forrestguice
Copy link
Owner Author

...further investigation.. it is the sunset date that is incorrect - the time is right (so the issue is never noticed), but the date is set to today (when it should be tomorrow). The noon calculation finds the midpoint between the rise and sunset times and in this case the sunset time is off by a full 24hrs.

the sunset time is retrieved directly from sunrisesunsetlib - very possible the bug originates there. a workaround is to check if the sunset time falls before the rise time and if so add a day.

forrestguice added a commit that referenced this issue Sep 29, 2016
work around bug described in #65
@forrestguice forrestguice added this to the v0.2.3 milestone Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant