Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search places doesn't work #566

Closed
forrestguice opened this issue Mar 4, 2022 · 0 comments · Fixed by #570
Closed

search places doesn't work #566

forrestguice opened this issue Mar 4, 2022 · 0 comments · Fixed by #570
Labels
Milestone

Comments

@forrestguice
Copy link
Owner

Trying to search for locations in the Places activity doesn't seem to work. The search menu item doesn't respond to presses - it should replace the text "Places" with an EditText that allows filtering the list.

There is an exception when the activity is first launched:

2022-03-04 10:08:25.407 25225-25225/? W/SupportMenuInflater: Cannot instantiate class: android.support.v7.widget.SearchView
    java.lang.NoSuchMethodException: android.support.v7.widget.SearchView.<init> [class android.content.Context]
        at java.lang.Class.getConstructor0(Class.java:2332)
        at java.lang.Class.getConstructor(Class.java:1728)
        at android.support.v7.view.SupportMenuInflater$MenuState.newInstance(SupportMenuInflater.java:502)
        at android.support.v7.view.SupportMenuInflater$MenuState.setItem(SupportMenuInflater.java:462)
        at android.support.v7.view.SupportMenuInflater$MenuState.addItem(SupportMenuInflater.java:483)
        at android.support.v7.view.SupportMenuInflater.parseMenu(SupportMenuInflater.java:200)
        at android.support.v7.view.SupportMenuInflater.inflate(SupportMenuInflater.java:122)
        at com.forrestguice.suntimeswidget.getfix.PlacesListFragment.onCreateOptionsMenu(PlacesListFragment.java:176)
        at android.support.v4.app.Fragment.performCreateOptionsMenu(Fragment.java:2353)
        at android.support.v4.app.FragmentManagerImpl.dispatchCreateOptionsMenu(FragmentManager.java:3088)
        at android.support.v4.app.FragmentController.dispatchCreateOptionsMenu(FragmentController.java:319)
        at android.support.v4.app.FragmentActivity.onCreatePanelMenu(FragmentActivity.java:363)
        at android.support.v7.view.WindowCallbackWrapper.onCreatePanelMenu(WindowCallbackWrapper.java:98)
        at android.support.v7.app.AppCompatDelegateImplBase$AppCompatWindowCallbackBase.onCreatePanelMenu(AppCompatDelegateImplBase.java:335)
        at android.support.v7.view.WindowCallbackWrapper.onCreatePanelMenu(WindowCallbackWrapper.java:98)
        at android.support.v7.app.ToolbarActionBar.populateOptionsMenu(ToolbarActionBar.java:454)
        at android.support.v7.app.ToolbarActionBar$1.run(ToolbarActionBar.java:61)
        at android.os.Handler.handleCallback(Handler.java:883)
        at android.os.Handler.dispatchMessage(Handler.java:100)
        at android.os.Looper.loop(Looper.java:241)
        at android.app.ActivityThread.main(ActivityThread.java:7604)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:941)

It tests correctly in the emulator running api31, and an older device running api19, but fails on another device running api30. The difference seems to be between debug and release mode - proguard appears to be at fault.

Since almost all users are running a release build, it seems this feature may have been broken since its introduction.

forrestguice added a commit that referenced this issue Mar 6, 2022
`android.support.v7.widget.SearchView` (#566)
@forrestguice forrestguice added this to the v0.14.2 milestone Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant