Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timezone setting ignored #34

Closed
forrestguice opened this issue Aug 10, 2016 · 3 comments
Closed

timezone setting ignored #34

forrestguice opened this issue Aug 10, 2016 · 3 comments
Labels
Milestone

Comments

@forrestguice
Copy link
Owner

forrestguice commented Aug 10, 2016

The timezone setting is being ignored when displaying 24 hour time.

It always displays using the system timezone, while displaying a mismatching label. Swapping timezones appears to do nothing, and if you aren't already aware of what the times are supposed to be beforehand, it makes it look like the calculation is completely wrong. If you are using a locale that toggles the 24hr time setting (de vs en), the problem appears to be locale dependent. Since custom timezone is off by default its not immediately noticeable.

using default lat/lon 35, -112...
System Settings -> Date & Time -> 24hr time -> on
System Settings -> Date & Time -> Select timezone -> America/New York
Suntimes App -> custom timezone -> America/Phoenix .. the reported sunrise time is ~ 08:45 (right time for new york, but is actually 5:45 in phoenix)

System Settings -> Date & Time -> 24hr time -> off
System Settings -> Date & Time -> Select timezone -> America/New York
Suntimes App -> custom timezone -> America/Phoenix .. the reported sunrise time is ~ 05:45 (right time)

The bug is present in v0.1.0, v0.1.1.

@forrestguice
Copy link
Owner Author

looked just about everywhere trying to figure this out, and thought it was somehow locale related. its not. the timezone is correct right up to display. cause is a single line, a missing call to DateFormat.setTimeZone in the calendarTimeShortDisplayString method.

@forrestguice
Copy link
Owner Author

hrm. I'm not sure I like the way that commit automatically closed the issue. I guess I'll have to avoid the word "fix" - preference is to close issues after the fix is included in a release.

@forrestguice forrestguice reopened this Aug 10, 2016
@forrestguice
Copy link
Owner Author

fixed in v0.2.0

@forrestguice forrestguice added this to the v0.2.0 milestone Aug 16, 2016
forrestguice added a commit that referenced this issue Apr 19, 2017
fix #34 again.. DateUtils.formatDateTime does not account for timezone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant