Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table switches unintentionally #20

Closed
HerHde opened this issue Jul 28, 2016 · 3 comments
Closed

Table switches unintentionally #20

HerHde opened this issue Jul 28, 2016 · 3 comments
Labels
bug
Milestone
v0.3.1

Comments

@HerHde
Copy link
Contributor

HerHde commented Jul 28, 2016

Ahoi Forrest,
another one here ;-)
The table in the main activity switches on some events that I would not expect.
It seems to switch between today and tomorrow e.g.:

  • when I am on today and click the note with the next note setting and vice versa
  • when I am on tomorrow and reactivate my screen or switch back from another app.
  • when I am on tomorrow and the clock shows the next minute.

The last two appear intended, what do you say?

Greetings
~HerHde
@forrestguice
Copy link
Owner

It happens when a timefield is highlighted by the note. For example, if it is currently after sunset and the note is for sunrise (tomorrow), it will highlight that field (swapping the cards if "today" is currently shown).

At the moment that happens whenever the note is updated, which is happening in each of the cases you describe. I think its that last one (when the clock shows the next minute) that is unexpected/annoying since it steals the view against the user's intention.

What is the right behavior here? We could disable highlighting the field entirely (no more transitions at all), or maybe detect when today/tomorrow have been explicitly swapped (and then prevent the highlighting from hijacking the view), or toggle behaviors w/ an option.

forrestguice added a commit that referenced this issue Aug 11, 2016
@forrestguice
fix table switches unintentionally
fd5bb72 
#20: the today/tomorrow card no longer switches when clock shows next
minute; the today/tomorrow card is retained when swapping apps / on
orientation change
@forrestguice
Copy link
Owner

fixed in v0.2.0

@forrestguice forrestguice added this to the v0.2.0 milestone Aug 16, 2016
@forrestguice
Copy link
Owner

...still a problem.

It works correctly when pressing the next ">" and prev "<" buttons, but swiping the view triggers the bug. Even a partial swipe (that doesn't trigger a card change) seems to reset the flag, and the next update switches the table.

tested against v0.2.1, v0.3.0 (api19)

@forrestguice forrestguice reopened this Mar 6, 2017
forrestguice added a commit that referenced this issue Mar 23, 2017
@forrestguice
test userSwappedCard
5d3ff39 
withSwipe, withNextButton
reproduces bug in #20
forrestguice added a commit that referenced this issue Apr 7, 2017
@forrestguice
userSwappedCard
42bdb0c 
fix for #20 .. it should only be possible to set flag true from touch
listener (the flag shouldn't be reset if failed to swap view).

To trigger the bug.. swipe, a double ACTION_UP occurs (caused by
"extended move" in ACTION_MOVE) - the first ACTION_UP swaps the view
(setting flag true), the second ACTION_UP tries again (and fails setting
flag false).
@forrestguice forrestguice modified the milestones: v0.3.1, v0.2.0 Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.3.1
Development

No branches or pull requests
2 participants
@HerHde @forrestguice