Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation to Dutch #30

Merged
merged 7 commits into from
Jan 28, 2021
Merged

translation to Dutch #30

merged 7 commits into from
Jan 28, 2021

Conversation

Joppla
Copy link
Contributor

@Joppla Joppla commented Jan 26, 2021

Please check if the Dutch word [agenda's] needs an escape character (\ or /) before the [ ' ]. I wasn't sure.

forrestguice and others added 4 commits January 19, 2021 12:12
adds Dutch (nl) to list of locale_values
prepare for translation to Dutch; adds `values-nl/strings.xml` (forrestguice#29)
Please check if the Dutch word [agenda's] need an escape character before  the  [ ' ]. I wasn't sure.
@forrestguice
Copy link
Owner

Thanks. I should have time to review/merge this in the next day or so.

btw, don't pay any attention to that failing check; the automated build seems to have been broken recently. Its something I'll have to fix.

@forrestguice forrestguice added this to the v0.5.1 milestone Jan 27, 2021
@forrestguice
Copy link
Owner

This looks good, thank you.
I'm going to tag v0.5.1 this weekend. It should hopefully be on F-Droid the week after.

btw the ' character does need to be escaped with a \ so I made that change. I also added some attribution (let me know if I should change that). If you aren't opposed, I'm going to migrate some of these values over to the main app as a starting point for future translation.

@Joppla
Copy link
Contributor Author

Joppla commented Jan 28, 2021

I m glad that you are happy with the result.

@forrestguice forrestguice changed the title Patch 1 translation to Dutch Jan 28, 2021
@forrestguice forrestguice merged commit c69aa7e into forrestguice:master Jan 28, 2021
@forrestguice forrestguice mentioned this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants