Fall back to modified time if creation time of cached binaries is unavailable #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to re-run the example script from the README in a podman container (Alpine Linux 3.17) I receive the following output:
In the container
~/.cache/
is on afuse-overlayfs
, which doesn't seem to expose file creation (called "Birth") time information:This seems to be introduced by the change here: ab77a62#diff-42cb6807ad74b3e201c5a7ca98b911c5fa08380e942be6e4ac5807f8377f87fcR364-R366
The issue is that this code assumes all files will have a creation time, while that's not true on Linux.
This commit makes no behavioral change if retrieving creation time is successful, but changes the error path to instead fall back to modified time if the creation time is missing (instead of erroring out).