Skip to content

Maybe added a callback at the end of the animation #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Maybe added a callback at the end of the animation #204

wants to merge 1 commit into from

Conversation

john-psina
Copy link

Resolves #37

@vercel Vercel
Copy link

vercel bot commented May 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auto-animate ❌ Failed (Inspect) May 29, 2024 2:45pm

Jorundur
Jorundur reviewed Mar 28, 2025
View reviewed changes
Copy link

@Jorundur Jorundur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm reading this correctly, it looks like the change here would run onEnd for each child of the parent node when the child finishes animating - wouldn't be better to have an onEnd run only once after all children have finished animating?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jorundur Jorundur Jorundur left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request] Add a callback option when animation is completed
2 participants
@john-psina @Jorundur