Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7589: hotfix for no return crash #12

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

brendanbond
Copy link
Contributor

@brendanbond brendanbond commented Nov 27, 2023

Link to Jira Ticket (if applicable)

https://formio.atlassian.net/browse/FIO-7589

Description

If no files were uploaded, the server will return a 400 but continue execution. Someone forgot a return statement if no files were uploaded.

Dependencies

n/a

How has this PR been tested?

n/a

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@lane-formio lane-formio changed the title hotfix for no return crash FIO-7589: hotfix for no return crash Nov 27, 2023
@AlexeyNikipelau
Copy link
Contributor

LGTM

@AlexeyNikipelau AlexeyNikipelau merged commit 433e163 into main Jan 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants