Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9902-9878: fixed an issue where PDF is not loaded for the form with hidden/conditionally hidden select #6074

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Mar 28, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9902
https://formio.atlassian.net/browse/FIO-9878

Description

What changed?

When the formio-viewer renders submission on the pdf-server, it waits until dataReady is resolved. But the dataReady is not resolved for list components when they are hidden that courses the PDF not to be generated. This PR fixes it.

Why have you chosen this solution?

Use this section to justify your choices

Breaking Changes / Backwards Compatibility

Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility

Dependencies

https://github.com/formio/premium/pull/389

How has this PR been tested?

manually + tests

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant