Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9921: fix issue with local paths not being propogated to edit grid #6072

Merged
merged 3 commits into from
Mar 27, 2025

Conversation

brendanbond
Copy link
Contributor

@brendanbond brendanbond commented Mar 27, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9921

Description

Since we made changes to the way components' paths are stored and constructed, one crucial element of a correct path is the "local" flag, which determines whether or not a component should be pathed as "local" (i.e. to the current form context) or not (i.e. when it is participating in the process as a nested form).

This PR fixes an issue in EditGrid in which the local option was not being passed to a specific validation step. What's odd is that EditGrid appears to be the only component that calls the invalidMessage function and that validation step appears to be redundant, but for the sake of risk factor and incrementalism I've decided to just pass the option rather than taking the drastic step of removing the function call entirely.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

I couldn't figure out a way to reliably reproduce this issue in our automated testing because the only indication that something is wrong is a visual error (the form will successfully submit regardless of the validation problem). I'm going to investigate THAT issue (the fact that an invalid child form's parent will still successfully submit) and return to this to write tests.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@johnformio johnformio merged commit 4b424b9 into master Mar 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants