Fixed edge cases for clearOnHide with nested forms + new test cases. #6068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-XXXX
Description
There was previously a file that would perform all the tests for clearOnHide within the "test/unit" folder. This file was unfortunately not being executed because it did not have the "unit.js" extension. Once I enabled this file, it indicated a few edge cases where the clearOnHide functionality was not working within nested forms.
This also highlighted a few performance issues with the existing checks being made, as well as some legacy code that was checking the isEmpty() for nested forms, which caused major performance issues as it would iterate through all the children to check their emptiness... this was only being added to fix a bug with regards to customDefaultValues in nested forms.
Breaking Changes / Backwards Compatibility
None
Dependencies
None
How has this PR been tested?
New automated tests added.
Checklist: