Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9888: Fixed issue where the noDefaults flag would skip defaults even for calculations. #6061

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

travist
Copy link
Member

@travist travist commented Mar 25, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9888

Description

Previously, we had a "noDefaults" flag, whose purpose is to not establish the default values for all components within a form when the form is initialized. The reason for this flag is to ensure that we "minify" the submission data when the form is established. This flag, however, should not skip over any calculated default values as well as any explicitly defined default values provided within the component settings. This change ensures that the defaults are still established if the calculated defaults are provided and the noDefaults flag is set in the form options.

Breaking Changes / Backwards Compatibility

None

Dependencies

None

How has this PR been tested?

The project settings form in the Developer Portal uses the "noDefaults" flag, but there are many calculated default values (such as API Keys) which need to still function with the noDefaults flag.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit fb771a0 into master Mar 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants