Skip to content

Conversation

@longlho
Copy link
Member

@longlho longlho commented Jan 6, 2026

TL;DR

Add a smoke test for rules_formatjs and include it in release artifacts.

What changed?

  • Created a new smoke test in e2e/smoke/ directory with a minimal setup to verify FormatJS CLI functionality
  • Updated BCR presubmit configuration to use the new smoke test instead of the previous example
  • Enhanced the release preparation script to include the smoke test in release artifacts
  • Added testing instructions to the release notes

How to test?

Run the smoke test with:

cd e2e/smoke
bazel build //:extract

This will extract messages from a simple React component and verify that the FormatJS CLI toolchain is working correctly.

Why make this change?

This change provides users with a simple way to verify that rules_formatjs works in their environment without needing to set up a complex example. Including the smoke test in the release artifact makes it easier for users to test the rules immediately after installation, improving the user experience and reducing potential setup issues.

@longlho longlho marked this pull request as ready for review January 6, 2026 12:18
Copy link
Member Author

longlho commented Jan 6, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@longlho longlho merged commit 5ef109d into main Jan 6, 2026
10 checks passed
Copy link
Member Author

longlho commented Jan 6, 2026

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant