fix(connectors): increase connector's timeout

[paul-nicolas]

No description provided.

[coderabbitai]

Walkthrough

The constant DefaultConnectorClientTimeout in the internal/models/plugin.go file was updated from 3 seconds to 10 seconds. No other files or logic were altered.

Changes

File(s)	Change Summary
internal/models/plugin.go	Increased DefaultConnectorClientTimeout from 3 to 10 seconds

Poem

A timeout once quick as a hop,
Now lingers—ten seconds, no stop.
The connectors can wait,
No need to be late,
As rabbits, we pause—then we pop! 🕰️🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b2172f0 and aa499c7.

📒 Files selected for processing (1)

• internal/models/plugin.go (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: laouji
PR: formancehq/payments#193
File: internal/connectors/plugins/public/dummypay/client/client.go:104-131
Timestamp: 2024-12-12T12:45:27.164Z
Learning: The `Balance` struct in `internal/connectors/plugins/public/dummypay/client/client.go` is only used in tests, so changing `AmountInMinors` from `int64` to `*big.Int` is not necessary.

Learnt from: gitstart-formance
PR: formancehq/payments#322
File: internal/connectors/plugins/public/increase/accounts.go:61-96
Timestamp: 2025-02-20T20:04:35.706Z
Learning: The Increase connector uses centralized constants from the client package for metadata keys (e.g., client.IncreaseTypeMetadataKey) rather than hardcoded strings.

Learnt from: paul-nicolas
PR: formancehq/payments#224
File: internal/api/v3/handler_bank_accounts_list.go:39-45
Timestamp: 2024-12-20T14:09:32.979Z
Learning: Paul-Nicolas prefers to keep in-place obfuscation in the bankAccountsList function since the error is returned immediately upon failure, rejecting the approach of making a copy first.

internal/models/plugin.go (2)

Learnt from: laouji
PR: formancehq/payments#193
File: internal/connectors/plugins/public/dummypay/client/client.go:104-131
Timestamp: 2024-12-12T12:45:27.164Z
Learning: The `Balance` struct in `internal/connectors/plugins/public/dummypay/client/client.go` is only used in tests, so changing `AmountInMinors` from `int64` to `*big.Int` is not necessary.

Learnt from: gitstart-formance
PR: formancehq/payments#322
File: internal/connectors/plugins/public/increase/accounts.go:61-96
Timestamp: 2025-02-20T20:04:35.706Z
Learning: The Increase connector uses centralized constants from the client package for metadata keys (e.g., client.IncreaseTypeMetadataKey) rather than hardcoded strings.

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Dirty

🔇 Additional comments (1)

internal/models/plugin.go (1)

9-9: Validate the 3 → 10 second jump and its ripple effect across connectors

DefaultConnectorClientTimeout is referenced by multiple connector clients that implicitly rely on the previous 3 s behaviour for retry/back-off logic. Before merging, please double-check:

1. No unit/integration tests assert the 3 s value.
2. Connectors that internally multiply/divide this constant (e.g., exponential back-off) still behave as expected.
3. The longer timeout doesn’t mask latency issues or block goroutine pools under load.

If everything looks good, feel free to ignore.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate Unit Tests

• Create PR with Unit Tests
• Post Copyable Unit Tests in Comment
• Commit Unit Tests in branch fix/timeout

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.65%. Comparing base (b2172f0) to head (aa499c7).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
- Coverage   69.65%   69.65%   -0.01%     
==========================================
  Files         627      627              
  Lines       32208    32208              
==========================================
- Hits        22436    22433       -3     
- Misses       8558     8560       +2     
- Partials     1214     1215       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.