fix: return 400 instead of 500 for idempotency key reuse with different body

docs/api/README.md

@@ -937,6 +937,7 @@ Authorization ( Scopes: ledger:write )
 DELETE http://localhost:8080/v2/{ledger}/transactions/{id}/metadata/{key} HTTP/1.1
 Host: localhost:8080
 Accept: application/json
+Idempotency-Key: string
 
 ```
 
@@ -951,6 +952,7 @@ Delete metadata by key
 |ledger|path|string|true|Name of the ledger.|
 |id|path|integer(bigint)|true|Transaction ID.|
 |key|path|string|true|The key to remove.|
+|Idempotency-Key|header|string|false|Use an idempotency key|
 
 > Example responses
 

internal/api/common/errors.go

@@ -2,11 +2,13 @@ package common
 
 import (
 	"errors"
+	"net/http"
+
 	"github.com/formancehq/go-libs/v2/api"
 	"github.com/formancehq/go-libs/v2/logging"
 	"github.com/formancehq/go-libs/v2/otlp"
 	"github.com/formancehq/go-libs/v2/platform/postgres"
-	"net/http"
+	ledgercontroller "github.com/formancehq/ledger/internal/controller/ledger"
 )
 
 const (
@@ -28,6 +30,22 @@ const (
 	ErrScriptMetadataOverride  = "METADATA_OVERRIDE"
 )
 
+// HandleCommonWriteErrors specifically handles errors related to write operations
+// such as idempotency errors
+func HandleCommonWriteErrors(w http.ResponseWriter, r *http.Request, err error) {
+	switch {
+	case errors.Is(err, ledgercontroller.ErrIdempotencyKeyConflict{}):
+		api.WriteErrorResponse(w, http.StatusConflict, ErrConflict, err)
+	case errors.Is(err, ledgercontroller.ErrInvalidIdempotencyInput{}):
+		api.BadRequest(w, ErrValidation, err)
+	case errors.Is(err, ledgercontroller.ErrNotFound):
+		api.NotFound(w, err)
+	default:
+		HandleCommonErrors(w, r, err)
+	}
+}
+
+// HandleCommonErrors handles more general common errors
 func HandleCommonErrors(w http.ResponseWriter, r *http.Request, err error) {
 	switch {
 	case errors.Is(err, postgres.ErrTooManyClient{}):

internal/api/v1/controllers_accounts_add_metadata.go

@@ -2,12 +2,14 @@ package v1
 
 import (
 	"encoding/json"
-	"github.com/formancehq/ledger/internal/controller/ledger"
-	"github.com/formancehq/ledger/pkg/accounts"
 	"net/http"
 	"net/url"
 
+	"github.com/formancehq/ledger/internal/controller/ledger"
+	"github.com/formancehq/ledger/pkg/accounts"
+
 	"errors"
+
 	"github.com/formancehq/go-libs/v2/api"
 	"github.com/formancehq/go-libs/v2/metadata"
 	"github.com/formancehq/ledger/internal/api/common"
@@ -38,7 +40,7 @@ func addAccountMetadata(w http.ResponseWriter, r *http.Request) {
 		Metadata: m,
 	}))
 	if err != nil {
-		common.HandleCommonErrors(w, r, err)
+		common.HandleCommonWriteErrors(w, r, err)
 		return
 	}
 

internal/api/v1/controllers_accounts_delete_metadata.go

@@ -1,10 +1,11 @@
 package v1
 
 import (
-	"github.com/formancehq/ledger/internal/controller/ledger"
 	"net/http"
 	"net/url"
 
+	"github.com/formancehq/ledger/internal/controller/ledger"
+
 	"github.com/formancehq/go-libs/v2/api"
 	"github.com/formancehq/ledger/internal/api/common"
 	"github.com/go-chi/chi/v5"
@@ -25,7 +26,7 @@ func deleteAccountMetadata(w http.ResponseWriter, r *http.Request) {
 				Key:     chi.URLParam(r, "key"),
 			}),
 		); err != nil {
-		common.HandleCommonErrors(w, r, err)
+		common.HandleCommonWriteErrors(w, r, err)
 		return
 	}
 

internal/api/v1/controllers_transactions_add_metadata.go

@@ -8,6 +8,7 @@ import (
 	ledgercontroller "github.com/formancehq/ledger/internal/controller/ledger"
 
 	"errors"
+
 	"github.com/formancehq/go-libs/v2/api"
 	"github.com/formancehq/go-libs/v2/metadata"
 	"github.com/formancehq/ledger/internal/api/common"
@@ -33,11 +34,10 @@ func addTransactionMetadata(w http.ResponseWriter, r *http.Request) {
 		TransactionID: int(txID),
 		Metadata:      m,
 	})); err != nil {
-		switch {
-		case errors.Is(err, ledgercontroller.ErrNotFound):
+		if errors.Is(err, ledgercontroller.ErrNotFound) {
 			api.NotFound(w, err)
-		default:
-			common.HandleCommonErrors(w, r, err)
+		} else {
+			common.HandleCommonWriteErrors(w, r, err)
 		}
 		return
 	}

internal/api/v1/controllers_transactions_create.go

@@ -9,6 +9,7 @@ import (
 	ledgercontroller "github.com/formancehq/ledger/internal/controller/ledger"
 
 	"errors"
+
 	"github.com/formancehq/go-libs/v2/api"
 	"github.com/formancehq/go-libs/v2/metadata"
 	"github.com/formancehq/go-libs/v2/time"
@@ -92,13 +93,12 @@ func createTransaction(w http.ResponseWriter, r *http.Request) {
 				api.BadRequest(w, common.ErrScriptCompilationFailed, err)
 			case errors.Is(err, &ledgercontroller.ErrMetadataOverride{}):
 				api.BadRequest(w, common.ErrScriptMetadataOverride, err)
-			case errors.Is(err, ledgercontroller.ErrNoPostings) ||
-				errors.Is(err, ledgercontroller.ErrInvalidIdempotencyInput{}):
+			case errors.Is(err, ledgercontroller.ErrNoPostings):
 				api.BadRequest(w, common.ErrValidation, err)
 			case errors.Is(err, ledgercontroller.ErrTransactionReferenceConflict{}):
 				api.WriteErrorResponse(w, http.StatusConflict, common.ErrConflict, err)
 			default:
-				common.HandleCommonErrors(w, r, err)
+				common.HandleCommonWriteErrors(w, r, err)
 			}
 			return
 		}
@@ -127,13 +127,12 @@ func createTransaction(w http.ResponseWriter, r *http.Request) {
 		case errors.Is(err, &ledgercontroller.ErrInvalidVars{}) ||
 			errors.Is(err, ledgercontroller.ErrCompilationFailed{}) ||
 			errors.Is(err, &ledgercontroller.ErrMetadataOverride{}) ||
-			errors.Is(err, ledgercontroller.ErrInvalidIdempotencyInput{}) ||
 			errors.Is(err, ledgercontroller.ErrNoPostings):
 			api.BadRequest(w, common.ErrValidation, err)
 		case errors.Is(err, ledgercontroller.ErrTransactionReferenceConflict{}):
 			api.WriteErrorResponse(w, http.StatusConflict, common.ErrConflict, err)
 		default:
-			common.HandleCommonErrors(w, r, err)
+			common.HandleCommonWriteErrors(w, r, err)
 		}
 		return
 	}

internal/api/v1/controllers_transactions_delete_metadata.go

@@ -7,6 +7,7 @@ import (
 	ledgercontroller "github.com/formancehq/ledger/internal/controller/ledger"
 
 	"errors"
+
 	"github.com/formancehq/go-libs/v2/api"
 	"github.com/formancehq/ledger/internal/api/common"
 	"github.com/go-chi/chi/v5"
@@ -27,12 +28,7 @@ func deleteTransactionMetadata(w http.ResponseWriter, r *http.Request) {
 		TransactionID: int(transactionID),
 		Key:           metadataKey,
 	})); err != nil {
-		switch {
-		case errors.Is(err, ledgercontroller.ErrNotFound):
-			api.NotFound(w, err)
-		default:
-			common.HandleCommonErrors(w, r, err)
-		}
+		common.HandleCommonWriteErrors(w, r, err)
 		return
 	}
 

internal/api/v2/controllers_accounts_add_metadata.go

@@ -1,15 +1,17 @@
+//go:build !wasm
+
 package v2
 
 import (
 	"encoding/json"
-	"github.com/formancehq/ledger/internal/controller/ledger"
+	"errors"
 	"net/http"
 	"net/url"
 
-	"errors"
 	"github.com/formancehq/go-libs/v2/api"
 	"github.com/formancehq/go-libs/v2/metadata"
 	"github.com/formancehq/ledger/internal/api/common"
+	"github.com/formancehq/ledger/internal/controller/ledger"
 	"github.com/go-chi/chi/v5"
 )
 
@@ -33,7 +35,7 @@ func addAccountMetadata(w http.ResponseWriter, r *http.Request) {
 		Metadata: m,
 	}))
 	if err != nil {
-		common.HandleCommonErrors(w, r, err)
+		common.HandleCommonWriteErrors(w, r, err)
 		return
 	}
 

internal/api/v2/controllers_accounts_delete_metadata.go

@@ -1,10 +1,11 @@
 package v2
 
 import (
-	"github.com/formancehq/ledger/internal/controller/ledger"
 	"net/http"
 	"net/url"
 
+	"github.com/formancehq/ledger/internal/controller/ledger"
+
 	"github.com/go-chi/chi/v5"
 
 	"github.com/formancehq/go-libs/v2/api"
@@ -26,7 +27,7 @@ func deleteAccountMetadata(w http.ResponseWriter, r *http.Request) {
 				Key:     chi.URLParam(r, "key"),
 			}),
 		); err != nil {
-		common.HandleCommonErrors(w, r, err)
+		common.HandleCommonWriteErrors(w, r, err)
 		return
 	}
 

internal/api/v2/controllers_ledgers_delete_metadata.go

@@ -1,9 +1,10 @@
 package v2
 
 import (
-	"github.com/formancehq/ledger/internal/api/common"
 	"net/http"
 
+	"github.com/formancehq/ledger/internal/api/common"
+
 	"github.com/formancehq/ledger/internal/controller/system"
 
 	"github.com/formancehq/go-libs/v2/api"
@@ -13,7 +14,7 @@ import (
 func deleteLedgerMetadata(b system.Controller) http.HandlerFunc {
 	return func(w http.ResponseWriter, r *http.Request) {
 		if err := b.DeleteLedgerMetadata(r.Context(), chi.URLParam(r, "ledger"), chi.URLParam(r, "key")); err != nil {
-			common.HandleCommonErrors(w, r, err)
+			common.HandleCommonWriteErrors(w, r, err)
 			return
 		}
 

internal/api/v2/controllers_ledgers_update_metadata.go

@@ -2,10 +2,12 @@ package v2
 
 import (
 	"encoding/json"
-	"github.com/formancehq/ledger/internal/api/common"
 	"net/http"
 
+	"github.com/formancehq/ledger/internal/api/common"
+
 	"errors"
+
 	"github.com/formancehq/go-libs/v2/api"
 	"github.com/formancehq/go-libs/v2/metadata"
 	systemcontroller "github.com/formancehq/ledger/internal/controller/system"
@@ -22,7 +24,7 @@ func updateLedgerMetadata(systemController systemcontroller.Controller) http.Han
 		}
 
 		if err := systemController.UpdateLedgerMetadata(r.Context(), chi.URLParam(r, "ledger"), m); err != nil {
-			common.HandleCommonErrors(w, r, err)
+			common.HandleCommonWriteErrors(w, r, err)
 			return
 		}
 

internal/api/v2/controllers_transactions_add_metadata.go

@@ -8,6 +8,7 @@ import (
 	ledgercontroller "github.com/formancehq/ledger/internal/controller/ledger"
 
 	"errors"
+
 	"github.com/formancehq/go-libs/v2/api"
 	"github.com/formancehq/go-libs/v2/metadata"
 	"github.com/formancehq/ledger/internal/api/common"
@@ -33,12 +34,7 @@ func addTransactionMetadata(w http.ResponseWriter, r *http.Request) {
 		TransactionID: int(txID),
 		Metadata:      m,
 	})); err != nil {
-		switch {
-		case errors.Is(err, ledgercontroller.ErrNotFound):
-			api.NotFound(w, err)
-		default:
-			common.HandleCommonErrors(w, r, err)
-		}
+		common.HandleCommonWriteErrors(w, r, err)
 		return
 	}
 

internal/api/v2/controllers_transactions_create.go

@@ -2,9 +2,10 @@ package v2
 
 import (
 	"encoding/json"
-	"github.com/formancehq/ledger/internal/api/bulking"
 	"net/http"
 
+	"github.com/formancehq/ledger/internal/api/bulking"
+
 	ledgercontroller "github.com/formancehq/ledger/internal/controller/ledger"
 
 	"errors"
@@ -51,14 +52,12 @@ func createTransaction(w http.ResponseWriter, r *http.Request) {
 			api.BadRequest(w, common.ErrNoPostings, err)
 		case errors.Is(err, ledgercontroller.ErrTransactionReferenceConflict{}):
 			api.WriteErrorResponse(w, http.StatusConflict, common.ErrConflict, err)
-		case errors.Is(err, ledgercontroller.ErrInvalidIdempotencyInput{}):
-			api.BadRequest(w, common.ErrValidation, err)
 		case errors.Is(err, ledgercontroller.ErrParsing{}):
 			api.BadRequest(w, common.ErrInterpreterParse, err)
 		case errors.Is(err, ledgercontroller.ErrRuntime{}):
 			api.BadRequest(w, common.ErrInterpreterRuntime, err)
 		default:
-			common.HandleCommonErrors(w, r, err)
+			common.HandleCommonWriteErrors(w, r, err)
 		}
 		return
 	}

internal/api/v2/controllers_transactions_delete_metadata.go

@@ -8,7 +8,6 @@ import (
 
 	"github.com/go-chi/chi/v5"
 
-	"errors"
 	"github.com/formancehq/ledger/internal/api/common"
 
 	"github.com/formancehq/go-libs/v2/api"
@@ -29,12 +28,7 @@ func deleteTransactionMetadata(w http.ResponseWriter, r *http.Request) {
 		TransactionID: int(txID),
 		Key:           metadataKey,
 	})); err != nil {
-		switch {
-		case errors.Is(err, ledgercontroller.ErrNotFound):
-			api.NotFound(w, err)
-		default:
-			common.HandleCommonErrors(w, r, err)
-		}
+		common.HandleCommonWriteErrors(w, r, err)
 		return
 	}
 

internal/api/v2/controllers_transactions_revert.go

@@ -7,6 +7,7 @@ import (
 	ledgercontroller "github.com/formancehq/ledger/internal/controller/ledger"
 
 	"errors"
+
 	"github.com/formancehq/go-libs/v2/api"
 	"github.com/formancehq/ledger/internal/api/common"
 	"github.com/go-chi/chi/v5"

openapi.yaml

@@ -1746,6 +1746,11 @@ paths:
           schema:
             type: string
             example: foo
+        - name: Idempotency-Key
+          in: header
+          description: Use an idempotency key
+          schema:
+            type: string
       responses:
         2XX:
           description: Key deleted
@@ -2116,6 +2121,11 @@ paths:
           schema:
             type: string
             example: foo
+        - name: Idempotency-Key
+          in: header
+          description: Use an idempotency key
+          schema:
+            type: string
       responses:
         2XX:
           description: Key deleted