fix: reverse query param on transactions list

[gfyrag]

No description provided.

[coderabbitai]

Walkthrough

The changes introduce support for dynamic ordering in the transaction list API by allowing clients to specify a "reverse" parameter to control the sort order. Corresponding end-to-end tests are added to verify that listing transactions with the reverse option returns results in ascending order.

Changes

File(s)	Change Summary
internal/api/v2/controllers_transactions_list.go	Added logic to detect a "reverse" query parameter and set the transaction list order accordingly.
test/e2e/api_transactions_list_test.go	Added a test case to verify transaction listing with the "reverse" option enabled.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant API_Controller
    participant DB_Query

    Client->>API_Controller: GET /transactions?reverse=true
    API_Controller->>API_Controller: Parse "reverse" parameter
    API_Controller->>DB_Query: getColumnPaginatedQuery(order=OrderAsc)
    DB_Query-->>API_Controller: Transactions (ascending)
    API_Controller-->>Client: Response with transactions (ascending order)

Loading

Poem

🐇
A flip of the switch, a change in the breeze,
Now transactions can list as you please.
Ascending or not, just set "reverse" true—
The API listens and sorts it for you!
With tests in the warren, all’s hopping anew.

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9e185b9 and 599afbe.

📒 Files selected for processing (2)

• internal/api/v2/controllers_transactions_list.go (1 hunks)
• test/e2e/api_transactions_list_test.go (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Dirty
• GitHub Check: Tests

🔇 Additional comments (4)

internal/api/v2/controllers_transactions_list.go (2)

22-25: Good implementation of the reverse parameter functionality.

The code cleanly introduces support for dynamic ordering by checking the "reverse" query parameter and toggling between descending and ascending order appropriately.

---

27-27: Correct usage of the dynamic order parameter.

The order variable is properly passed to the getColumnPaginatedQuery function, enabling the transaction list to be sorted according to the client's request.

test/e2e/api_transactions_list_test.go (2)

23-23: Appropriate import for the test case.

The slices package is correctly imported to support the test functionality.

---

107-129: Well-structured test for the new reverse parameter functionality.

The test case thoroughly verifies the behavior of the transaction listing API when the Reverse option is enabled. It correctly:

1. Sets up the test with appropriate parameters
2. Performs the API request with the reverse flag set to true
3. Validates that the returned transactions match the expected subset in ascending order
4. Uses slices.Reverse appropriately to prepare the expected data

This test properly complements the implementation in the controller.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (9e185b9) to head (599afbe).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
- Coverage   81.94%   81.80%   -0.14%     
==========================================
  Files         141      141              
  Lines        7752     7756       +4     
==========================================
- Hits         6352     6345       -7     
- Misses       1074     1082       +8     
- Partials      326      329       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.