Skip to content

fix: missing filter on list logs #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gfyrag merged 1 commit into from
Feb 25, 2025
Merged

fix: missing filter on list logs #709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/storage/ledger/logs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,4 +239,13 @@ func TestLogsList(t *testing.T) {
// Should get only the second log, as StartTime is inclusive and EndTime exclusive.
require.Len(t, cursor.Data, 1)
require.EqualValues(t, 2, *cursor.Data[0].ID)

cursor, err = store.Logs().Paginate(context.Background(), ledgercontroller.ColumnPaginatedQuery[any]{
PageSize: 10,
Options: ledgercontroller.ResourceQuery[any]{
Builder: query.Lt("id", 3),
},
})
require.NoError(t, err)
require.Equal(t, 2, len(cursor.Data))
}
5 changes: 4 additions & 1 deletion internal/storage/ledger/resource_logs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ func (h logsResourceHandler) filters() []filter {
// todo: add validators
name: "date",
},
{
name: "id",
},
}
}

Expand All @@ -27,7 +30,7 @@ func (h logsResourceHandler) buildDataset(store *Store, _ repositoryHandlerBuild

func (h logsResourceHandler) resolveFilter(_ *Store, _ ledgercontroller.ResourceQuery[any], operator, property string, value any) (string, []any, error) {
switch {
case property == "date":
case property == "date" || property == "id":
return fmt.Sprintf("%s %s ?", property, convertOperatorToSQL(operator)), []any{value}, nil
default:
return "", nil, fmt.Errorf("unknown key '%s' when building query", property)
Expand Down