feat: handle missing compatibility layer with v2.1

[gfyrag]

No description provided.

[coderabbitai]

Walkthrough

The changes introduce new paginated resource adapters for various ledger entities in the legacy storage system. These adapters provide methods for retrieving, counting, and paginating accounts, logs, transactions, aggregated balances, and volumes. The DefaultStoreAdapter has been updated to conditionally return these new adapters based on a flag, allowing for flexible data retrieval with pagination support across different ledger resources.

Changes

File	Changes
internal/storage/ledger/legacy/adapters.go	- Added new paginated resource adapter types for accounts, logs, transactions, aggregated balances, and volumes - Implemented GetOne, Count, and Paginate methods for each adapter - Modified DefaultStoreAdapter to use new adapters conditionally

Poem

🐰 Hop, hop, through the ledger's maze,
Pagination now dances with grace!
Accounts, logs, and transactions flow,
With adapters that help data grow 📊
A rabbit's tale of storage delight! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (4)

internal/storage/ledger/legacy/adapters.go (4)

76-79: Panic usage in Log adapter methods
Both GetOne and Count panic here. Consider returning an error instead of panicking to avoid crashing the service if these methods are accidentally invoked.

Also applies to: 80-82

---

157-181: Big integer usage
The method starts each output balance at new(big.Int) and uses Add. A direct Set(balance) could be more explicit, e.g., Input = new(big.Int).Set(balance). Otherwise, logic looks solid for constructing aggregated volumes.

---

183-185: Panic in Count
Again, consider returning an appropriate error rather than panicking, to safeguard runtime stability.

---

208-210: Panic in GetOne and Count
Returning an error is typically safer than panicking for unimplemented methods.

Also applies to: 212-214

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b1cb3cf and 6af5838.

📒 Files selected for processing (1)

• internal/storage/ledger/legacy/adapters.go (1 hunks)

🔇 Additional comments (20)

internal/storage/ledger/legacy/adapters.go (20)

6-6: No concerns on new imports
The newly introduced imports (bunpaginate, math/big, and slices) appear consistent with the newly added pagination and big integer functionalities.

Also applies to: 14-15

---

18-20: Struct definition is straightforward
The accountsPaginatedResourceAdapter with a *Store pointer looks appropriate for the intended usage.

---

22-39: Type assertion safety
In the GetOne method, the code asserts value.(string) at line 25. If query.Builder unexpectedly yields a non-string value, it may cause a runtime panic. Consider handling or validating the type to guard against malformed queries.

---

41-53: Counting accounts with expansions
Though expansions like volumes or effective volumes generally do not affect record count, the code passes these flags into the store query. This is typically fine, but ensure that expansions don’t unintentionally impact performance or logic in the count routine.

---

55-68: Pagination logic
The code properly uses GetAccountsWithVolumes with page-sized queries. Ensure that the underlying store handles edge cases such as zero or negative page sizes.

---

70-70: Compile-time interface check
This line confirms that accountsPaginatedResourceAdapter implements the PaginatedResource interface. No issues.

---

72-74: Struct definition
The logsPaginatedResourceAdapter with a store field maintains a consistent approach.

---

84-95: Logs pagination
Using p.store.GetLogs is consistent with the rest of the pattern. No immediate concerns.

---

97-98: Compile-time interface check
Verifies logsPaginatedResourceAdapter meets PaginatedResource requirements. Looks good.

---

99-101: Transactions adapter struct
The transactionsPaginatedResourceAdapter mirrors the accounts/logs adapters. The approach remains consistent.

---

103-120: Type assertion safety
In GetOne, the code asserts value.(int) at line 106. Similar to the accounts adapter, consider confirming the type if invalid input might pass through the builder.

---

122-134: Transactions count
Acceptable usage of CountTransactions. Ensure expansions do not degrade performance if they’re unnecessary for counting.

---

136-149: Transactions pagination
Logic is consistent with the codebase's approach to pagination. No immediate concerns.

---

151-152: Compile-time interface check
Confirms transactionsPaginatedResourceAdapter aligns with PaginatedResource.

---

153-155: Aggregated balances adapter
Basic struct definition follows the same pattern as other adapters.

---

187-188: Compile-time interface check
No concerns here.

---

189-191: Aggregated volumes adapter
Struct definition is analogous to the others.

---

193-206: Aggregated volumes pagination
Logic for retrieving volumes with balances is in harmony with the existing approach.

---

216-217: Compile-time interface check
Ensures the aggregated volumes adapter fulfills PaginatedResource.

---

225-227: Conditional adapter delegation
All these condition checks in the DefaultStoreAdapter properly toggle between legacy and new store adapters via isFullUpToDate. No issues found.

Also applies to: 232-234, 239-241, 246-248, 253-255