Added dictionary comprehensions

forma-ai · Dec 2, 2015 · a3da24c · a3da24c
1 parent 81ccf5f
commit a3da24c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/simple_history/management/commands/_populate_utils.py b/simple_history/management/commands/_populate_utils.py
@@ -21,7 +21,9 @@ def bulk_history_create(model, history_model):
         history_model(
             history_date=getattr(instance, '_history_date', now()),
             history_user=getattr(instance, '_history_user', None),
-            **dict((field.attname, getattr(instance, field.attname))
-                   for field in instance._meta.fields)
+            **{
+                field.attname: getattr(instance, field.attname)
+                for field in instance._meta.fields
+            }
         ) for instance in model.objects.all()]
     history_model.objects.bulk_create(historical_instances)
diff --git a/simple_history/models.py b/simple_history/models.py
@@ -179,8 +179,10 @@ def revert_url(self):
                     [getattr(self, opts.pk.attname), self.history_id])
 
         def get_instance(self):
-            return model(**dict([(field.attname, getattr(self, field.attname))
-                                for field in fields.values()]))
+            return model(**{
+                field.attname: getattr(self, field.attname)
+                for field in fields.values()
+            })
 
         return {
             'history_id': models.AutoField(primary_key=True),