This repository has been archived by the owner on Aug 10, 2021. It is now read-only.
Fix security vulnerability #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a security vulnerability where a jwt token could potentially be validated having invalid string characters.
giorgos-f3
commented
Jun 24, 2021
| @@ -0,0 +1,3 @@ | |||
| module github.com/form3tech-oss/jwt-go | |||
There was a problem hiding this comment.
should it be directed to the original repo i wonder 🤔
iyigunform3
approved these changes
Jun 25, 2021
markhowardform3
approved these changes
Jun 25, 2021
This was referenced Jul 29, 2021
thaJeztah
pushed a commit
to thaJeztah/jwt
that referenced
this pull request
Jul 29, 2021
Fixes a security vulnerability where a jwt token could potentially be validated having invalid string characters. (cherry picked from commit a211650c6ae1cff6d7347d3e24070d65dcfb1122) form3tech-oss/jwt-go#14 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
pushed a commit
to thaJeztah/jwt
that referenced
this pull request
Jul 29, 2021
Fixes a security vulnerability where a jwt token could potentially be validated having invalid string characters. (cherry picked from commit a211650c6ae1cff6d7347d3e24070d65dcfb1122) form3tech-oss/jwt-go#14 Co-Authored-By: Giorgos Lampadakis <82932062+giorgos-f3@users.noreply.github.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
oxisto
pushed a commit
to golang-jwt/jwt
that referenced
this pull request
Jul 30, 2021
Fixes a security vulnerability where a jwt token could potentially be validated having invalid string characters. (cherry picked from commit a211650c6ae1cff6d7347d3e24070d65dcfb1122) form3tech-oss/jwt-go#14 Co-Authored-By: Giorgos Lampadakis <82932062+giorgos-f3@users.noreply.github.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Right now, if you were to validate the expires_at, not_before, and issued_at jwt fields while not setting them up as required.. Even if the presented value was an invalid string, the verification would pass.
Solution
Make sure that if the type is not expected, we return false. The presented solution should not cause any breaking changes.
Also, proceeded to add modules.