Skip to content

Block unlocker marking all blocks as orphaned #48

Open

Description

@CaptainMeatloaf

I'm attempting to set up a pool for turtlecoin (https://github.com/turtlecoin/turtlecoin), at http://turtlepool.space, and appear to be having issues with getting the pool to unlock the blocks correctly.

UPDATE: For those using TurtleCoin, this was fixed, this bug still may apply to other cryptonote currencies.

I have set up the daemon and wallet (using simplewallet), and the pool appears to connect to them and read ok.

image
I then set up my miner to mine to the pool. It has managed to find several successful blocks, however when a block is discovered, the block becomes orphaned after the maturity depth has passed.

There are no obvious errors in any of the logs.

Upon further inspection, it appears that there is an off-by-one error in blockUnlocker.js.

This can be temporarily fixed by changing line 48 of blockUnlocker.js from
apiInterfaces.rpcDaemon('getblockheaderbyheight', {height: block.height}, function(error, result){
to
apiInterfaces.rpcDaemon('getblockheaderbyheight', {height: block.height + 1}, function(error, result){

However this feels like somewhat of a hack.

Please let me know if you need any more info.

Activity

  1. changed the title [-]Forknote pool not reading block worth correctly[/-] [+]Block unlocker marking all blocks as orphaned[/+] on Dec 12, 2017
  2. pipozzz commented on Dec 26, 2017

    @pipozzz

    How did you do reprocessing of bad labeled blocks?

  3. CaptainMeatloaf commented on Dec 26, 2017

    @CaptainMeatloaf
    Author

    I didn't - as I was solo mining and it was a testing phase for the pool, all the blocks found went to me anyway

  4. BisWang commented on Feb 11, 2018

    @BisWang

    I have high rate orphan on my turtlecoin pool, but I use the same forknote-pool on intense coin it have normal orphan rate
    This problem cause by turtlecoin or?

  5. CaptainMeatloaf commented on Feb 11, 2018

    @CaptainMeatloaf
    Author

    That's a bug in Turtlecoin that we as the pool ops have a fix for - ask on discord.

  6. fairmarketcoin commented on Mar 12, 2018

    @fairmarketcoin

    what's the fix for this at the coins level?

  7. alferz commented on Mar 18, 2018

    @alferz

    Same issue on leviarcoin. I made the same fix as OP, but does anyone have a better one? Maybe an option in the config file to address the off by one issue for crappily coded coins?

  8. madradio commented on Mar 20, 2018

    @madradio

    Could anyone of you post the fix for this issue here?

  9. CaptainMeatloaf commented on Mar 20, 2018

    @CaptainMeatloaf
    Author

    You can look at the commit history of TurtleCoin to find the fix, it was done pretty early on

  10. mohs27 commented on Dec 8, 2021

    @mohs27

    UPX1YM7hv26AEuddTb648tcRU3SyYAr8AdjA74bkpdJ64H2nFdDt5eRNVBkez1dy8RFBW9enaEqs39gW8QJgv5ei5- - ### - [x] Dp3qq1P56@madradio @mohs27 SAVE_۲۰۲۱۱۲۰۸_۱۰۳۲۲۵.jpg****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions