Fix for removing items from dicts #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe the problem lies in the way recursive calls are made? |
Also added pytest-cov to get an idea of what the code coverage is. Apparently lines 98-99 of diff.py were exactly *not* covered. Simply adding a test where an item is removed from a dict hits those two lines. Bonus: pytest-watch in dev tools.
berendkleinhaneveld
changed the title
Korijn
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16 .
I didn't yet try to minimise the test, but simply adding/removing an item from a dict seemed to work fine, even though I would also expect that to hit the line I changed in diff.py?Seems that line 98-99 of diff.py were not covered in the tests. And those lines can be triggered by removing an item from a dict.
Weird thing is: #16 contains a failing example where an item is added to a dict...
I'm still a bit confused...And that happens because of how the diffs between lists are calculated (line 88 kind of switches input/output).