Skip to content

Fixes for (reverse) ops #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 18, 2022
Merged

Fixes for (reverse) ops #15

merged 6 commits into from
Feb 18, 2022

Conversation

berendkleinhaneveld
Copy link
Collaborator

@berendkleinhaneveld berendkleinhaneveld commented Feb 18, 2022 •
edited
Loading

This PR changes the following:

  • Add more (basic) tests
  • Fix for indices in list comparisons for both ops and rops
  • Fix for padding of rops, taking into account the length of the output instead of input

@berendkleinhaneveld berendkleinhaneveld changed the title Fix for the reverse ops when more than two items are to be removed Fixes for (reverse) ops Feb 18, 2022
Korijn
Korijn reviewed Feb 18, 2022
View reviewed changes
@berendkleinhaneveld berendkleinhaneveld marked this pull request as ready for review February 18, 2022 16:40
@Korijn Korijn merged commit 250efa0 into master Feb 18, 2022
@Korijn Korijn deleted the fix-list-reverse-ops branch February 18, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Korijn Korijn Korijn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berendkleinhaneveld @Korijn