Skip to content

Ignore unsuported style attributes #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ignore unsuported style attributes #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions delta/html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,13 @@ def styled(element, styles):
if element.tag != 'span':
element = sub_element(element, 'span')
declare = parseStyle(element.attrib.get('style', ''))
for k, v in styles.items():
declare.setProperty(k, v)
element.attrib['style'] = declare.getCssText(' ')
try:
for k, v in styles.items():
declare.setProperty(k, v)
element.attrib['style'] = declare.getCssText(' ')
except:
# Ignore invalid css attributes
pass
return element

def classed(element, *classes):
Expand Down
15 changes: 15 additions & 0 deletions tests/test_html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,21 @@ def test_colors():
source = '<p><span style="background-color: #000; color: #FFF">quill</span></p>'
assert html.render(ops) == source

def test_unsupported_style_attribute():
ops = [
{"insert": "quill", "attributes": {"color": "var(--some-color)", "background": "#000000"}}
]

source = '<p><span style="background-color: #000">quill</span></p>'
assert html.render(ops) == source

ops = [
{"insert": "quill", "attributes": {"background": "#000000", "color": "#FFFFFF"}}
]

source = '<p><span style="background-color: #000; color: #FFF">quill</span></p>'
assert html.render(ops) == source

def test_classes():
ops = [
{"insert":"Quill", "attributes": {"font": "monospace", "size": "huge"}}
Expand Down