Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for creation of Java Records #239

Merged
merged 1 commit into from
May 21, 2022
Merged

Better support for creation of Java Records #239

merged 1 commit into from
May 21, 2022

Conversation

gastaldi
Copy link
Member

@gastaldi gastaldi commented May 21, 2022

This should enable the creation of Java records

Example:

      final JavaRecordSource javaRecord = Roaster.create(JavaRecordSource.class)
               .setName("PhoneNumber")
               .setPackage("org.example.foo");
      javaRecord.addRecordComponent(BigInteger.class, "number");
      javaRecord.addMethod().setName("dial").setReturnType(boolean.class).setBody("return true;");

Generates:

package org.example.foo;

import java.math.BigInteger;

public record PhoneNumber(BigInteger number) {

	boolean dial() {
		return true;
	}
}

Refactored default implementations in MethodHolder

Suport methods in Records
@gastaldi gastaldi linked an issue May 21, 2022 that may be closed by this pull request
@gastaldi
Copy link
Member Author

/cc @maxandersen

@maxandersen
Copy link
Member

works! LGTM!

@gastaldi gastaldi merged commit 6530621 into master May 21, 2022
@gastaldi gastaldi deleted the record branch May 21, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot generate record source ?
2 participants