Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full URLs to the website location of Information files #57

Closed
maurolepore opened this issue May 29, 2019 · 0 comments
Closed

Add full URLs to the website location of Information files #57

maurolepore opened this issue May 29, 2019 · 0 comments

Comments

@maurolepore
Copy link
Contributor

maurolepore commented May 29, 2019

In R-devel, CRAN now checks for full URLs when doing a new submisison (see also r-lib/usethis#772).

TODO

Change relative to full links at https://github.com/forestgeo/fgeo.plot/blob/master/README.Rmd

Bad:

* [Getting help](SUPPORT.md).
* [Contributing](CONTRIBUTING.md).
* [Contributor Code of Conduct](CODE_OF_CONDUCT.md).

Good:

* [Getting help](https://forestgeo.github.io/fgeo.plot/SUPPORT.html).
* [Contributing](https://forestgeo.github.io/fgeo.plot/CONTRIBUTING.html).
* [Contributor Code of Conduct](https://forestgeo.github.io/fgeo.plot/CODE_OF_CONDUCT.html).

Rejection email

Sent: Wednesday, May 29, 2019 3:40 AM
Subject: Re: CRAN submission fgeo.plot 1.1.7

Thanks, we see:

   Found the following (possibly) invalid file URIs:
     URI: .github/SUPPORT.md
       From: README.md
     URI: .github/CONTRIBUTING.md
       From: README.md
     URI: .github/CODE_OF_CONDUCT.md
       From: README.md

These files do not exist.
Better add full URLs to the github location of these files?

Please fix and resubmit.

Best,
Uwe Ligges

@maurolepore maurolepore changed the title Add full URLs to the website location of Information files? Add full URLs to the website location of Information files May 29, 2019
@fgeocomm fgeocomm mentioned this issue May 29, 2019
maurolepore added a commit that referenced this issue May 30, 2019
fgeocomm added a commit to fgeocomm/fgeo.plot that referenced this issue May 31, 2019
maurolepore added a commit to maurolepore/fgeo.plot that referenced this issue May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant