-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add supercluster visualization #162
Conversation
…ially; need to style and add markers
…and appearance for larger clusters
…r size and work out color based on events
…ed to nail down styling and add onSelect for clusters
… into individual clusters and points
…de and only allowing locations to contain valid coordinates
…gure UI to both zoom and select events
…PR to get feedback
Love this feature. Do you want general comments regarding what's missing and bugs, or just inline comments on the code reviewing what you've done so far? |
…dd a var that's read from the config to determine styling: radial gradient || normal opacity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really excellent work/feature! I've made a couple of structural suggestions around code quality. I haven't been able to test the feature yet in a browser, due to having the wrong config I think (have sent you a message privately).
const extraRender = () => ( | ||
<React.Fragment> | ||
{customStyles[1]} | ||
</React.Fragment> | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This extraRender
logic is a good candidate for making into a HOC now, I think, given that it's used both here and in Events.jsx.
This PR should be fully ready to review. I've attached the appropriate timemap config file here. Note that the categories are currently broken on this branch, but you shouldn't need to test with them anyways. The styling for the clusters (opacity, size, cluster radius) are the ones decided on in the chat, but any and all suggestions welcome. In order to run locally with updated data, I created a
|
…ugh componentDidUpdate method
This is a preliminary PR to get feedback for the supercluster visualization. Currently, the styles are still in question (opacity, size of cluster, cluster radius) and we will be reviewing different styles soon to gauge what is best for the user.
See comment below for more updated information