[Emojis in Markdown] #1653
Merged
[Emojis in Markdown] #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds the ability to add emojis using colons 😂 🎉 - The emoji conversion is added to the markdown parser labor - When no emoji is found with the alias, same text is returned - No assets added (no emoji images), so this will only be supported when the browser supports emojis (https://blog.getemoji.com/post/57054354336/which-browsers-support-emoji) - Emoji conversion logic is out of markdown parser labor - Adds its own spec
juanmanuelramallo
force-pushed
the
feature/emojis-in-markdown
branch
from
cd9f899 to
06a0faf
Compare
|
@benhalpern Thoughts on this? |
benhalpern
approved these changes
Jan 28, 2019
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
|
Congrats! Feel free to write a changelog post (tagged |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
:joy: :tada:Related Tickets & Documents
#203
#849
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Not applicable
Added to documentation?