FFM-42656 Added ability to block uploads on networks in "Low Data Mode" #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in "Low Data Mode"
moshe-foreflight
approved these changes
Jun 13, 2025
| internal struct DataUploadConditions { | ||
| enum Blocker { | ||
| case battery(level: Int, state: BatteryStatus.State) | ||
| case lowDataModeOn |
There was a problem hiding this comment.
Precision here to match Apple's API might be a good idea. allowsConstrained... or whatever URLRequest calls it.
There was a problem hiding this comment.
Good idea 👍 I renamed this and a few others to better match allowsConstrainedNetworkAccess
| case let .battery(level: level, state: state): | ||
| return "🔋 Battery state is: \(state) (\(level)%)" | ||
| case .lowDataModeOn: | ||
| return "🛜 Network is in Low Data Mode and uploads are disabled for constrained networks" |
DatadogCore/Sources/Datadog.swift
Outdated
|
|
||
| /// Allows uploads on constrained networks | ||
| /// | ||
| /// Defaults to `true` but can be overridden to block uploads on networks with "Low Data Mode" enabled |
There was a problem hiding this comment.
Are "block"ed uploads cancelled or deferred? Is that explicitly understood here, or do we want to specify?
Suggested change
| /// Defaults to `true` but can be overridden to block uploads on networks with "Low Data Mode" enabled | |
| /// Defaults to `true` but can be overridden to block uploads on networks with "Low Data Mode" enabled. |
There was a problem hiding this comment.
Blocked uploads are deferred and I updated this comment to make that more clear
…s "allowsConstrainedNetworkAccess"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
This PR adds a
constrainedNetworkUploadsDisabledproperty which allows users to configure whether or not the SDK blocks uploads on constrained networks. This property defaults tofalseto keep the existing behavior.How?
The SDK is already tracking whether or not the network is constrained in NWPathMonitorPublisher and has a mechanism for blocking uploads with DataUploadConditions.blockersForUpload(). This PR updates
blockersForUpload()to check theisConstrainednetwork property. IfisConstrainedistrueand theconstrainedNetworkUploadsDisabledparameter istrue, the upload is blocked.Review checklist
make api-surface)