fix: only delete non-forceignored sub-directories #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
approved these changes
Feb 8, 2023
| } | ||
|
|
||
| this.logger.debug( | ||
| `Local component (${comp.fullName}) contains ${fileName} while remote component does not. This file is being removed.` | ||
| ); | ||
| deleteLocalComp = true; |
QA Notes✅ : add a file to a LWC, retrieve it, new file is gone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When retrieving bundle type metadata that has some pieces of the bundle deleted (or it looks that way because there are more local files than what was retrieved), only delete the pieces that are not forceignored.
What issues does this PR fix or reference?
@W-12460543@
forcedotcom/cli#1904
Functionality Before
would delete the entire component and replace with what was retrieved if there was any file within the component locally that was not retrieved, even if forceignored.
Functionality After
Removes pieces of a component only if they are not forceignored and they were not part of the retrieve.