fix: use parent xml to parse child - #470
Merged
Merged
Conversation
WillieRuemmele
approved these changes
Oct 11, 2021
Member
|
QA notes:
|
WillieRuemmele
approved these changes
Oct 11, 2021
mshanemc
reviewed
Oct 11, 2021
|
|
||
| // A cache of SourceComponent xml file paths to parsed contents so that identical child xml | ||
| // files are not read and parsed multiple times. | ||
| private parsedXmlCache = new Map<string, JsonMap>(); |
Contributor
There was a problem hiding this comment.
why keep this around at the class level if it's only used inside one recompose method? It could be kinda big for those large-number-of-labels scenarios.
Contributor
Author
There was a problem hiding this comment.
It should be really small actually. In the case of custom labels there would only be 1 entry per CustomLabels.labels-meta.xml file, which is only 1 per package directory. This could possibly be moved to within the recompose function but I wasn't sure if there were situations where multiple parent CustomLabels would exist in a ComponentSet so to be safe I added this as an instance var.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reuses the parsed custom labels file when parsing the children to improve conversion performance.
What issues does this PR fix or reference?
forcedotcom/cli#1194
@W-9990964@
Functionality Before
converting CustomLabels would take a long time since it would read and parse the CustomLabels.labels file for each label (child) within the file.
Functionality After
The CustomLabels.labels file is read and parsed once, then reused to parse the children.
Testing Notes: