-
Notifications
You must be signed in to change notification settings - Fork 133
feat: update from manifest initializer #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/collections/types.ts
Outdated
resolveSourcePaths?: string[]; | ||
/** | ||
* By default, wildcard members encoutered in the manifest are added to the set | ||
* e.g. `{ fullName: '*', type: 'ApexClass' }`. If `resolvePaths` is set, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is resolvePaths referring to resolveSourcePaths?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed it is, good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor doc updates - rest looks good.
Co-authored-by: Shelby Holden <45604118+sfsholden@users.noreply.github.com>
What does this PR do?
Updates the signature for the manifest initializer with the following:
Refactors some functionality:
ManifestResolver
class to mirror the one we have for resolving source (should be renamed toSourceResovler
perhaps). This cleans and simplifies the ComponentSet class a bit more.Breaks some stuff:
ComponentSet.fromManifest()
resolve
option toresolveSourcePaths
literalWildcard
option toforceAddWildcards
Adds better documentation:
fromManifest
What issues does this PR fix or reference?
@W-9070541@
Functionality Before
Functionality After