fix: set an overridden apiVersion on a created connection #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a connection that is created from a username should use the apiVersion passed rather than the default
brpowell
approved these changes
Mar 23, 2021
sfsholden
approved these changes
Mar 23, 2021
sfsholden
pushed a commit
that referenced
this pull request
Mar 30, 2021
a connection that is created from a username should use the apiVersion passed rather than the default
sfsholden
pushed a commit
that referenced
this pull request
Mar 30, 2021
a connection that is created from a username should use the apiVersion passed rather than the default
sfsholden
pushed a commit
that referenced
this pull request
May 6, 2021
a connection that is created from a username should use the apiVersion passed rather than the default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A connection that is created from a username should use the apiVersion passed rather than the default. Consumers of the API can then pass a username and an apiVersion and the created connection will have the apiVersion set for them.
This is currently possible if the consumer creates the Connection themselves and sets the apiVersion but that approach has potential problems with the version of
@salesforce/coreConnection in use by the consumer.What issues does this PR fix or reference?
@W-8942811@
Functionality Before
Setting apiVersion on the ComponentSet would not apply to the created Connection.
Functionality After
Setting apiVersion on the ComponentSet now applies to the created Connection.