Support split CustomLabels #273
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternhale
reviewed
Mar 23, 2021
Comment on lines
31
to
41
| const writeInfos: WriteInfo[] = []; | ||
| for (const [fsPath, labels] of [...index.entries()]) { | ||
| const customLabelsObj = deepmerge({}, allLabelsXml); | ||
| const filteredLabels = this.filterLabels(customLabelsObj, labels); | ||
| set(customLabelsObj, 'CustomLabels.labels', filteredLabels); | ||
| writeInfos.push({ | ||
| source: new JsToXml(customLabelsObj), | ||
| output: fsPath, | ||
| }); | ||
| } | ||
| return writeInfos; |
There was a problem hiding this comment.
Suggested change
| const writeInfos: WriteInfo[] = []; | |
| for (const [fsPath, labels] of [...index.entries()]) { | |
| const customLabelsObj = deepmerge({}, allLabelsXml); | |
| const filteredLabels = this.filterLabels(customLabelsObj, labels); | |
| set(customLabelsObj, 'CustomLabels.labels', filteredLabels); | |
| writeInfos.push({ | |
| source: new JsToXml(customLabelsObj), | |
| output: fsPath, | |
| }); | |
| } | |
| return writeInfos; | |
| return [...index.entries()].map(([fsPath, labels]) => { | |
| const customLabelsObj = deepmerge({}, allLabelsXml); | |
| const filteredLabels = this.filterLabels(customLabelsObj, labels); | |
| set(customLabelsObj, 'CustomLabels.labels', filteredLabels); | |
| return ({ | |
| source: new JsToXml(customLabelsObj), | |
| output: fsPath, | |
| }); | |
| } |
peternhale
approved these changes
Mar 23, 2021
| ? (fileProperties[0] as FileProperties) | ||
| : (fileProperties as FileProperties[]); | ||
| retrieveStatus.fileProperties = fileProperties as FileProperties[]; | ||
| // fileProperties.length === 1 |
mdonnalley
force-pushed
the
mdonnalley/custom-labels
branch
from
d9a1e2e to
769b201
Compare
|
Closed in favor of #278 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support retrieving CustomLabels that are split across multiple package directories
What issues does this PR fix or reference?
@W-9016030@
Functionality Before
All labels were retrieved into default package directory
Functionality After
Labels are retrieved into the directory to which they belong. New labels are added to the default directory
TODO: