fix: merge deploy api options #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will merge deploy api options with the defaults rather than using them only when undefined
shetzel
commented
Mar 23, 2021
| @@ -189,7 +189,8 @@ export class MetadataApiDeploy extends MetadataTransfer<MetadataApiDeployStatus, | |||
|
|
|||
| constructor(options: MetadataApiDeployOptions) { | |||
| super(options); | |||
| this.options = Object.assign({}, MetadataApiDeploy.DEFAULT_OPTIONS, options); | |||
| options.apiOptions = { ...MetadataApiDeploy.DEFAULT_OPTIONS.apiOptions, ...options.apiOptions }; | |||
| this.options = Object.assign({}, options); | |||
There was a problem hiding this comment.
Multiple ways to do this, and maybe it becomes MetadataApiDeploy.DEFAULT_API_OPTIONS but that was a more disruptive change so thought I'd start with this.
lcampos
approved these changes
Mar 23, 2021
brpowell
approved these changes
Mar 23, 2021
sfsholden
pushed a commit
that referenced
this pull request
Mar 30, 2021
this will merge deploy api options with the defaults rather than using them only when undefined
sfsholden
pushed a commit
that referenced
this pull request
Mar 30, 2021
this will merge deploy api options with the defaults rather than using them only when undefined
sfsholden
pushed a commit
that referenced
this pull request
May 6, 2021
this will merge deploy api options with the defaults rather than using them only when undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This will merge deploy api options with the defaults rather than using them only when undefined
What issues does this PR fix or reference?
@W-8942811@
Functionality Before
If partial api options were defined during the deploy, it would use those and not apply the defaults which would cause problems. If no api options were defined it would use the defaults.
Functionality After
If partial api options are defined during the deploy, it merges the defaults. This allows the defaults to be used when some options are specified and some are not.