fix: child components not being deployed #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brpowell
commented
Dec 3, 2020
src/collections/componentSet.ts
Outdated
| @@ -183,7 +183,7 @@ export class ComponentSet implements Iterable<MetadataComponent> { | |||
| public getObject(): PackageManifestObject { | |||
| const typeMap = new Map<string, string[]>(); | |||
| for (const key of this.components.keys()) { | |||
| const [typeId, fullName] = key.split('.'); | |||
| const [typeId, fullName] = key.split(ComponentSet.KEY_DELIMETER); | |||
There was a problem hiding this comment.
The problem was the delimiter for the key was being split by a ., which is bad because . is used in the fullname of a child component, i.e. My_Object__c.My_Field__c. Changed it to a # instead.
lcampos
approved these changes
Dec 3, 2020
brpowell
pushed a commit
that referenced
this pull request
Dec 8, 2020
brpowell
pushed a commit
that referenced
this pull request
Dec 8, 2020
sfsholden
pushed a commit
that referenced
this pull request
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where deploying individual child components like CustomField fails.
What issues does this PR fix or reference?
@W-8534562@