fix: add component to component set even when source unresolved #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brpowell
commented
Dec 3, 2020
| @@ -13,6 +13,7 @@ export { | |||
| MetadataApiDeployOptions, | |||
| RetrieveOptions, | |||
| RetrievePathOptions, | |||
| RetrieveStatus, | |||
There was a problem hiding this comment.
Should have been a public export
lcampos
approved these changes
Dec 3, 2020
brpowell
pushed a commit
that referenced
this pull request
Dec 3, 2020
brpowell
pushed a commit
that referenced
this pull request
Dec 3, 2020
sfsholden
pushed a commit
that referenced
this pull request
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a non SourceComponent to a ComponentSet when initializing with fromManifestFile and source was not found for a member in the file.
What issues does this PR fix or reference?
@W-8532624@