fix: handle nulls/undefined in template literal #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
commented
Jul 19, 2024
| @@ -147,7 +148,9 @@ export class DigitalExperienceSourceAdapter extends BundleSourceAdapter { | |||
| // 3 because we want 'digitalExperiences' directory, 'baseType' directory and 'bundleName' directory | |||
| const basePath = pathParts.slice(0, typeFolderIndex + 3).join(sep); | |||
| const bundleFileName = pathParts[typeFolderIndex + 2]; | |||
| const suffix = this.isBundleType() ? this.type.suffix : this.registry.getParentType(this.type.id)?.suffix; | |||
| const suffix = ensureString( | |||
There was a problem hiding this comment.
this will throw, so ex: if the metadataRegistry ever loses a suffix for DEB stuff, it'll fail tests
mdonnalley
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
if it's logging/debug, insert some placeholder to indicate that it's not present
for values used in "real" code, preserve existing behavior. Many of these are from inadequate types on the metadataRegistry (ex: DEB or StaticResource have a suffix, etc)
What issues does this PR fix or reference?
@ W-16116290@