fix: forceignore ignores output file correctly - cleanup extra type d… #1295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forceIgnoredPaths
were not getting set properlyinstead of using them, instantiate a forceignore parser, and check the validated, source paths correctly
What does this PR do?
What issues does this PR fix or reference?
#forcedotcom/cli#2737, @W-15303749@ @W-15578640@
Functionality Before
adding
**/Admin.profile-meta.xml
in your.forceignore
and runningsf project retrieve start -m Profile:Admin
would outputand write the file
**/profiles/**
in.forceignore
➜ sf project deploy start -m ApexClass:FileUtilities ApexClass:PagedResult Profile:Admin
would throw an error
Functionality After
it outputs the same message, but WILL NOT WRITE the file
➜ sf project deploy start -m ApexClass:FileUtilities ApexClass:PagedResult Profile:Admin
will now only deploy the ApexClasses