Skip to content

fix: forceignore ignores output file correctly - cleanup extra type d… #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

WillieRuemmele
Copy link
Member

@WillieRuemmele WillieRuemmele commented Apr 22, 2024

forceIgnoredPaths were not getting set properly
instead of using them, instantiate a forceignore parser, and check the validated, source paths correctly

What does this PR do?

What issues does this PR fix or reference?

#forcedotcom/cli#2737, @W-15303749@ @W-15578640@

Functionality Before

adding **/Admin.profile-meta.xml in your .forceignore and running
sf project retrieve start -m Profile:Admin would output

Retrieving v60.0 metadata from test-vzakcdis7lod@example.com using the v60.0 SOAP API
Preparing retrieve request... Succeeded
 ›   Warning: Nothing retrieved

and write the file


**/profiles/** in .forceignore

➜ sf project deploy start -m ApexClass:FileUtilities ApexClass:PagedResult Profile:Admin
would throw an error

Functionality After

it outputs the same message, but WILL NOT WRITE the file


➜ sf project deploy start -m ApexClass:FileUtilities ApexClass:PagedResult Profile:Admin
will now only deploy the ApexClasses

@WillieRuemmele WillieRuemmele requested a review from a team as a code owner April 22, 2024 22:33
@shetzel
Copy link
Contributor

shetzel commented Apr 25, 2024

QA: both commands behave as expected with changes. Tests look good.

@shetzel shetzel merged commit 287b13e into main Apr 25, 2024
68 checks passed
@shetzel shetzel deleted the wr/forceIgnore branch April 25, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants