feat: allow destructive changes with MetadataOptions #1294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
approved these changes
Apr 22, 2024
| dirsAreIdentical(path.join(snapshotsDir, 'testOutput', 'post1'), postTestOutputDir); | ||
| }); | ||
|
|
||
| it('2 post-destructive and 2 deployments', async () => { |
There was a problem hiding this comment.
should/could we add a test covering 1+ pre or post destructive changes, without any constructive? Seems like it'll be working - but would be good to have for future changes
There was a problem hiding this comment.
or maybe we don't want to support that? if the CLIs not adding new flags to use this, I'm not sure if other SDR consumers would like that ability
There was a problem hiding this comment.
I can add a test for those cases. 👍
QA Notes
const c = await ComponentSetBuilder.build({metadata:{
directoryPaths:['force-app/main/default/classes'],
destructiveEntriesPost: ['ApexClass:myClassPOST'],
destructiveEntriesPre: ['ApexClass:myClassPRE'],
metadataEntries: ['ApexClass:myClass']
}})
const p = await c.getPackageXml(4, DestructiveChangesType.PRE);
const x = await c.getPackageXml(4, DestructiveChangesType.POST);
// eslint-disable-next-line no-console
console.log(p,x);✅ : I ensured that both variables, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows defining metadata type/name pairs to be deleted (pre or post) as part of a metadata deploy. Adds snapshot tests for this behavior.
What issues does this PR fix or reference?
@W-15306474@